This is an archive of the discontinued LLVM Phabricator instance.

AVX512F: Assembler Intel syntax.
ClosedPublic

Authored by igorb on Feb 22 2016, 12:40 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 48652.Feb 22 2016, 12:40 AM
igorb retitled this revision from to AVX512F: Assembler Intel syntax..
igorb updated this object.
igorb added reviewers: delena, AsafBadouh, m_zuckerman.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
AsafBadouh accepted this revision.Feb 22 2016, 12:53 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 22 2016, 12:53 AM
delena edited edge metadata.Feb 22 2016, 12:59 AM

I don't see any intel-synax test. I don't understand why the test changes are relevant.

lib/Target/X86/X86InstrAVX512.td
7599 ↗(On Diff #48652)

any test for this change?

igorb marked an inline comment as done.Feb 22 2016, 1:07 AM

I don't see any intel-synax test. I don't understand why the test changes are relevant.

Test added to intel-syntax-avx512.s file - number of changes (37,570 lines)

lib/Target/X86/X86InstrAVX512.td
7599 ↗(On Diff #48652)

yes, in intel-syntax-avx512.s file

igorb updated this revision to Diff 48665.Feb 22 2016, 4:01 AM
igorb edited edge metadata.
igorb marked an inline comment as done.

patch spited (D17500 commited) .
Thanks for your comments.

delena accepted this revision.Feb 22 2016, 4:27 AM
delena edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.
llvm/trunk/lib/Target/X86/X86InstrAVX512.td