This is an archive of the discontinued LLVM Phabricator instance.

Differential D17384

Fix OSX cmake build
ClosedPublic

Authored by EwanCrawford on Feb 18 2016, 8:36 AM.

Details

Reviewers
sivachandra
zturner
labath
Commits
rGc6bef146caf6: Fix OSX cmake build
rLLDB261227: Fix OSX cmake build
rL261227: Fix OSX cmake build
Summary

Commit r260721(http://reviews.llvm.org/D17182) introduced the following error when building for OSX using cmake:

Undefined symbols for architecture x86_64:

"_PyInit__lldb", referenced from:
   -exported_symbol[s_list] command line option

ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Adding '*' to the regex solves this problem but I'm building with Python 2.7 instead of 3 so can't test thoroughly.

Diff Detail

Repository
rL LLVM

Event Timeline

EwanCrawford updated this revision to Diff 48325.Feb 18 2016, 8:36 AM
EwanCrawford retitled this revision from to Fix OSX cmake build.
EwanCrawford updated this object.
EwanCrawford added reviewers: sivachandra, zturner, labath.
EwanCrawford set the repository for this revision to rL LLVM.
EwanCrawford added a subscriber: lldb-commits.
zturner edited edge metadata.Feb 18 2016, 8:39 AM
zturner added a subscriber: zturner.

Ahh, I guess that's why that star was there before, maybe it makes the
entire symbol optional? Anyway lgtm

labath accepted this revision.Feb 18 2016, 8:45 AM
labath edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2016, 8:45 AM
Closed by commit rL261227: Fix OSX cmake build (authored by EwanCrawford). · Explain WhyFeb 18 2016, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
source/
API/
2 lines

Diff 48336

lldb/trunk/source/API/liblldb.exports

_ZN4lldb* _ZN4lldb*
_ZNK4lldb* _ZNK4lldb*
init_lld* init_lld*
PyInit__lldb PyInit__lldb*