This is an archive of the discontinued LLVM Phabricator instance.

Add additional Hi/Lo registers to Clang MipsTargetInfoBase
ClosedPublic

Authored by hvarga on Feb 18 2016, 6:41 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hvarga updated this revision to Diff 48309.Feb 18 2016, 6:41 AM
hvarga retitled this revision from to Add additional Hi/Lo registers to Clang MipsTargetInfoBase .
hvarga updated this object.
hvarga added reviewers: hfinkel, atrick, chandlerc.
hvarga added subscribers: cfe-commits, petarj.

I'm not sure if I added all of the necessary reviewers or even the correct ones. So please feel free to correct this if it's wrong.

Are there any thoughts about this patch?

chandlerc edited edge metadata.Mar 28 2016, 3:13 PM

I don't know anything about MIPS and this seems a highly MIPS specific change, so I can't provide any useful review here. You have someone with MIPS specific knowledge on the review though, so you seem to have the appropriate people looped in...

dsanders accepted this revision.Mar 29 2016, 1:41 AM
dsanders edited edge metadata.

LGTM

Sorry for missing this when it was first posted. I've also been away for roughly half of the two weeks since Petar added me to the review.

This revision is now accepted and ready to land.Mar 29 2016, 1:41 AM
This revision was automatically updated to reflect the committed changes.