Page MenuHomePhabricator

[X86] PR26575: Fix LEA optimization pass.
ClosedPublic

Authored by aturetsk on Feb 15 2016, 3:04 AM.

Details

Summary

Add a missing check for a type of address displacement operand of the load/store instruction being a candidate for LEA substitution.

Ref: https://llvm.org/bugs/show_bug.cgi?id=26575

Diff Detail

Repository
rL LLVM

Event Timeline

aturetsk updated this revision to Diff 47967.Feb 15 2016, 3:04 AM
aturetsk retitled this revision from to [X86] PR26575: Fix LEA optimization pass..
aturetsk updated this object.
aturetsk added reviewers: qcolombet, nadav, hans.
aturetsk added a subscriber: llvm-commits.
qcolombet accepted this revision.Feb 15 2016, 12:48 PM
qcolombet edited edge metadata.
This revision is now accepted and ready to land.Feb 15 2016, 12:48 PM

Just one comment, please use a more descriptive name for the filename than the pr number.

Thanks,
-Quentin

test/CodeGen/X86/pr26575.ll
16 ↗(On Diff #47967)

Check that the generated code looks reasonable.

This revision was automatically updated to reflect the committed changes.

Thanks for the review. The test's name was changed and sanity checks were added before the commit.