Defines instruction itineraries for common MIPSR6 instructions.
Details
Diff Detail
Event Timeline
LGTM with few small changes, the most important being the addition of the entries missing from the MipsGenericItineraries table.
lib/Target/Mips/Mips32r6InstrInfo.td | ||
---|---|---|
248–249 | Can we move the InstrItinClass parameter at the of the parameter list, in order to have the instruction's operands next to each other? Similarly for the 2-3 cases below. | |
lib/Target/Mips/MipsSchedule.td | ||
39 | We don't have an entry for this in the MipsGenericItineraries table. Similarly for II_BCCC below. | |
test/CodeGen/Mips/divrem.ll | ||
158 | I think that we have to use -DAG here as the order of the div/mod instructions doesn't require a strict order. Similarly for the cases below. | |
test/CodeGen/Mips/llvm-ir/mul.ll | ||
172–175 | We should use the -DAG suffix for these. Also, can you rename the temporaries in order to have an increasing numbering. Similarly, for 64R6 below. |
Can we move the InstrItinClass parameter at the of the parameter list, in order to have the instruction's operands next to each other? Similarly for the 2-3 cases below.