This is an archive of the discontinued LLVM Phabricator instance.

Differential D17193

Remove LLVMGetTargetMachineData in go-binding.
ClosedPublic

Authored by hokein on Feb 12 2016, 3:24 AM.

Download Raw Diff

Details

Reviewers

bkramer

Commits

rGebe01560a371: Remove LLVMGetTargetMachineData in go-binding.
rL260670: Remove LLVMGetTargetMachineData in go-binding.

Summary

LLVMGetTargetMachineData has been removed, and LLVMGetDataLayout is
suggested to use. The LLVMGetDataLayout is exposed in go bindings.
So it's safe to remove the function.

Diff Detail

Event Timeline

hokein updated this revision to Diff 47784.Feb 12 2016, 3:24 AM

hokein retitled this revision from to Remove LLVMGetTargetMachineData in go-binding..

hokein updated this object.

Herald added a subscriber: axw. · View Herald TranscriptFeb 12 2016, 3:24 AM

hokein set the repository for this revision to rL LLVM.Feb 12 2016, 3:31 AM

LGTM

This revision is now accepted and ready to land.Feb 12 2016, 3:33 AM

Closed by commit rL260670: Remove LLVMGetTargetMachineData in go-binding. (authored by hokein). · Explain WhyFeb 12 2016, 3:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

bindings/

go/

llvm/

target.go

5 lines

Diff 47784

bindings/go/llvm/target.go

	Show First 20 Lines • Show All 261 Lines • ▼ Show 20 Lines
	}			}

	// Triple returns the triple describing the machine (arch-vendor-os).			// Triple returns the triple describing the machine (arch-vendor-os).
	func (tm TargetMachine) Triple() string {			func (tm TargetMachine) Triple() string {
	cstr := C.LLVMGetTargetMachineTriple(tm.C)			cstr := C.LLVMGetTargetMachineTriple(tm.C)
	return C.GoString(cstr)			return C.GoString(cstr)
	}			}

	// TargetData returns the TargetData for the machine.
	func (tm TargetMachine) TargetData() TargetData {
	return TargetData{C.LLVMGetTargetMachineData(tm.C)}
	}

	func (tm TargetMachine) EmitToMemoryBuffer(m Module, ft CodeGenFileType) (MemoryBuffer, error) {			func (tm TargetMachine) EmitToMemoryBuffer(m Module, ft CodeGenFileType) (MemoryBuffer, error) {
	var errstr *C.char			var errstr *C.char
	var mb MemoryBuffer			var mb MemoryBuffer
	fail := C.LLVMTargetMachineEmitToMemoryBuffer(tm.C, m.C, C.LLVMCodeGenFileType(ft), &errstr, &mb.C)			fail := C.LLVMTargetMachineEmitToMemoryBuffer(tm.C, m.C, C.LLVMCodeGenFileType(ft), &errstr, &mb.C)
	if fail != 0 {			if fail != 0 {
	err := errors.New(C.GoString(errstr))			err := errors.New(C.GoString(errstr))
	C.free(unsafe.Pointer(errstr))			C.free(unsafe.Pointer(errstr))
	return MemoryBuffer{}, err			return MemoryBuffer{}, err
	Show All 19 Lines