[libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

[dsanders]

Hi,

I'd like to merge this to the 3.8 branch once it has been accepted.

[bcraig]

LGTM, but that doesn't mean much.

I suspect that there are some tests that have snuck past this sweep, but I haven't done the work to figure out which ones. I base this statement off of these search results...
LOCALE_en_US_UTF_8 found in 78 files underneath libcxx/test (prior to this change)
locale.en_US.UTF-8 found in 46 files underneath libcxx/test (prior to this change)
23 new instances of locale.en_US.UTF-8 in this change.

That suggests that there are at least 78 - (46+23) = 9 files that mention LOCALE_en_US_UTF_8 that don't have the REQUIRES clause. Maybe some other REQUIRES clause is making it so your test runs work. In my opinion, it is fine to leave that work for someone else.

[dsanders]

Added one more. It was also guarded by a check for ru_RU.UTF-8 so it was missed on the first sweep.

[dsanders]

Thanks. I've added one more which came up after enabling all the missing locales except for en_US.UTF-8.

I'll commit this and find the other 8 with grep afterwards.

test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <fstream>
 
 // int_type overflow(int_type c = traits::eof());
 
 // This test is not entirely portable
 
 #include <fstream>
 #include <cassert>

test/std/input.output/file.streams/fstreams/filebuf.virtuals/underflow.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <fstream>
 
 // int_type underflow();
 
 // This test is not entirely portable
 
 #include <fstream>
 #include <cassert>

test/std/input.output/iostream.format/ext.manip/get_time.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <iomanip>
 
 // template <class charT> T9 get_time(struct tm* tmb, const charT* fmt);
 
 #include <iomanip>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/input.output/iostream.format/ext.manip/put_time.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <iomanip>
 
 // template <class charT> T10 put_time(const struct tm* tmb, const charT* fmt);
 
 #include <iomanip>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/input.output/iostreams.base/ios.base/ios.base.callback/register_callback.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <ios>
 
 // class ios_base
 
 // void register_callback(event_callback fn, int index);
 
 #include <ios>
 #include <string>

test/std/input.output/iostreams.base/ios.base/ios.base.locales/imbue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <ios>
 
 // class ios_base
 
 // locale imbue(const locale& loc);
 
 #include <ios>
 #include <string>

test/std/input.output/iostreams.base/ios/basic.ios.members/imbue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <ios>
 
 // template <class charT, class traits> class basic_ios
 
 // locale imbue(const locale& loc);
 
 #include <ios>
 #include <streambuf>

test/std/input.output/stream.buffers/streambuf/streambuf.cons/copy.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <streambuf>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // basic_streambuf(const basic_streambuf& rhs);
 
 #include <streambuf>

test/std/input.output/stream.buffers/streambuf/streambuf.cons/default.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <streambuf>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // basic_streambuf();
 
 #include <streambuf>

test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.assign/assign.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <streambuf>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // basic_streambuf& operator=(const basic_streambuf& rhs);
 
 #include <streambuf>

test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.assign/swap.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <streambuf>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_streambuf;
 
 // void swap(basic_streambuf& rhs);
 
 #include <streambuf>

test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // template <class charT> class collate_byname
 
 // long hash(const charT* low, const charT* high) const;
 
 //   This test is not portable
 

test/std/localization/locale.categories/category.collate/locale.collate.byname/types.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // template <class charT>
 // class collate_byname
 //     : public collate<charT>
 // {
 // public:
 //     typedef basic_string<charT> string_type;

test/std/localization/locale.categories/category.ctype/locale.codecvt.byname/ctor_wchar_t.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // template <> class codecvt_byname<wchar_t, char, mbstate_t>
 
 // explicit codecvt_byname(const char* nm, size_t refs = 0);
 // explicit codecvt_byname(const string& nm, size_t refs = 0);
 
 #include <locale>

test/std/localization/locale.categories/category.ctype/locale.ctype.byname/types.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // template <class CharT>
 // class ctype_byname
 //     : public ctype<CharT>
 // {
 // public:
 //     explicit ctype_byname(const char*, size_t = 0);

test/std/localization/locales/locale/locale.cons/default.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // locale() throw();
 
 #include <locale>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/localization/locales/locale/locale.members/name.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // basic_string<char> name() const;
 
 #include <locale>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/localization/locales/locale/locale.operators/eq.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // basic_string<char> name() const;
 
 #include <locale>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/localization/locales/locale/locale.statics/global.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <locale>
 
 // static const locale& classic();
 
 #include <locale>
 #include <cassert>
 
 #include "platform_support.h" // locale name macros

test/std/re/re.regex/re.regex.locale/imbue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <regex>
 
 // template <class charT, class traits = regex_traits<charT>> class basic_regex;
 
 // locale_type imbue(locale_type loc);
 
 #include <regex>
 #include <locale>

test/std/re/re.traits/default.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <regex>
 
 // template <class charT> struct regex_traits;
 
 // regex_traits();
 
 #include <regex>
 #include <cassert>

test/std/re/re.traits/getloc.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <regex>
 
 // template <class charT> struct regex_traits;
 
 // locale_type getloc()const;
 
 #include <regex>
 #include <cassert>

test/std/re/re.traits/imbue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
+// REQUIRES: locale.en_US.UTF-8
+
 // <regex>
 
 // template <class charT> struct regex_traits;
 
 // locale_type imbue(locale_type l);
 
 #include <regex>
 #include <locale>