cover all width and types (pd/ps/sd/ss) of fixupimm instruction and inrtinsics
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
| E:/Work/LLVM/trunk/lib/Target/X86/X86InstrAVX512.td | ||
|---|---|---|
| 7529 | why _.MemOp and not _.ScalarMemOp ? If you change it i think you can remove defm rmi_alt | |
| E:/Work/LLVM/trunk/test/CodeGen/X86/avx512-intrinsics.ll | ||
| 7046 | please remove empty lines. | |
| E:/Work/LLVM/trunk/test/CodeGen/X86/avx512vl-intrinsics.ll | ||
| 7708 | could you please remove zeroinitializer from the tests? It only complicate checks. | |
| 7753 | please remove empty lines | |
| E:/Work/LLVM/trunk/test/CodeGen/X86/avx512vl-intrinsics.ll | ||
|---|---|---|
| 7708 | I think that this zeroinitializer is necessary since you can create fixupimmup {k}{z} with the non-maskz intrinsic version, and that case check it's ok. what do you think? | |
| E:/Work/LLVM/trunk/test/CodeGen/X86/avx512vl-intrinsics.ll | ||
|---|---|---|
| 7708 | ok | |
why _.MemOp and not _.ScalarMemOp ? If you change it i think you can remove defm rmi_alt