[test-suite] Move LDFLAGS to after objects

[mcrosier]

Summary

LDFLAGS were previously added after other compilation flags when
linking, but not after object files. This causes an issue when
attempting to statically compile, as objects cannot pull from libraries
put before them on the link line. This change assures that LDFLAGS is
always appended after the object files.

[MatzeB]

It surprised me that target_link_libraries can be used for arbitrary flags, but the cmake docu says so so this is fine.
I wonder if you can just replace the two append_ldflags(${source_exename} LDFLAGS) calls with target_link_libraries(${source_exename} ${LDFLAGS}) and remove the whole append_ldflags macro?

[mcrosier]

Committed r258056.

cmake/modules/SingleMultiSource.cmake

     string(REPLACE ";" " " s "${old_cflags};${${flags}}")
     set_target_properties(${target} PROPERTIES COMPILE_FLAGS ${s})
   endif()
 endmacro()
 
 # append_ldflags - add flags to the LDFLAGS for target.
 macro(append_ldflags target flags)
   if(NOT "${${flags}}" STREQUAL "")
-    get_target_property(old_ldflags ${target} LINK_FLAGS)
-    if(${old_ldflags} STREQUAL "old_ldflags-NOTFOUND")
-      set(old_ldflags)
-    endif()
-    string(REPLACE ";" " " s "${old_ldflags};${${flags}}")
-    set_target_properties(${target} PROPERTIES LINK_FLAGS ${s})
+    foreach(var IN LISTS ${flags})
+      target_link_libraries(${target} ${var})
+    endforeach()
   endif()
 endmacro()
 
 # llvm_add_test - Create a .test driver file suitable for LIT.
 #
 # The test template lives in cmake/lit-test-template.in and is configured by this function.
 function(llvm_add_test name exename)
   # Fall back to old style involving RUN_OPTIONS and STDIN_FILENAME if