This is an archive of the discontinued LLVM Phabricator instance.

Differential D16138

Correct setting of UserLabelPrefix for MCU target
ClosedPublic

Authored by andreybokhanko on Jan 13 2016, 2:29 AM.

Details

Reviewers
mkuper
• rafael
rnk
Commits
rG4f8867fc630b: Correct setting of UserLabelPrefix for MCU target.
rC257756: Correct setting of UserLabelPrefix for MCU target.
rL257756: Correct setting of UserLabelPrefix for MCU target.
Summary

Correct setting of UserLabelPrefix for MCU target

Diff Detail

Event Timeline

andreybokhanko updated this revision to Diff 44722.Jan 13 2016, 2:29 AM
andreybokhanko retitled this revision from to Correct setting of UserLabelPrefix for MCU target.
andreybokhanko updated this object.
andreybokhanko added reviewers: rnk, mkuper.
andreybokhanko added a subscriber: cfe-commits.
andreybokhanko updated this revision to Diff 44726.Jan 13 2016, 3:00 AM

Patch updated to be in line with llvm trunk. Sorry for the noise.

• rafael accepted this revision.Jan 13 2016, 5:57 AM
• rafael added a reviewer: • rafael.
• rafael added a subscriber: • rafael.

LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far more common than "_".

This revision is now accepted and ready to land.Jan 13 2016, 5:57 AM
andreybokhanko added a comment.Jan 14 2016, 2:47 AM

@rafael, thank you!

In D16138#325739, @rafael wrote:

LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far more common than "_".

Sure, will do.

Yours,
Andrey

Closed by commit rL257756: Correct setting of UserLabelPrefix for MCU target. (authored by asbokhan). · Explain WhyJan 14 2016, 3:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Basic/
1 line
test/
Preprocessor/
1 line

Diff 44722

lib/Basic/Targets.cpp

Show First 20 Lines • Show All 3,856 Lines • ▼ Show 20 Lines
}; };
// X86-32 MCU target // X86-32 MCU target
class MCUX86_32TargetInfo : public X86_32TargetInfo { class MCUX86_32TargetInfo : public X86_32TargetInfo {
public: public:
MCUX86_32TargetInfo(const llvm::Triple &Triple) : X86_32TargetInfo(Triple) { MCUX86_32TargetInfo(const llvm::Triple &Triple) : X86_32TargetInfo(Triple) {
LongDoubleWidth = 64; LongDoubleWidth = 64;
LongDoubleFormat = &llvm::APFloat::IEEEdouble; LongDoubleFormat = &llvm::APFloat::IEEEdouble;
UserLabelPrefix = "";
} }
CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { CallingConvCheckResult checkCallingConvention(CallingConv CC) const override {
// On MCU we support only C calling convention. // On MCU we support only C calling convention.
return CC == CC_C ? CCCR_OK : CCCR_Warning; return CC == CC_C ? CCCR_OK : CCCR_Warning;
} }
void getTargetDefines(const LangOptions &Opts, void getTargetDefines(const LangOptions &Opts,
▲ Show 20 Lines • Show All 3,900 Lines • Show Last 20 Lines

test/Preprocessor/elfiamcu-predefines.c

// RUN: %clang_cc1 -E -dM -triple i586-intel-elfiamcu | FileCheck %s // RUN: %clang_cc1 -E -dM -triple i586-intel-elfiamcu | FileCheck %s
// CHECK: #define __USER_LABEL_PREFIX__ {{$}}
// CHECK: #define __iamcu // CHECK: #define __iamcu
// CHECK: #define __iamcu__ // CHECK: #define __iamcu__