Page MenuHomePhabricator

Correct setting of UserLabelPrefix for MCU target
ClosedPublic

Authored by andreybokhanko on Jan 13 2016, 2:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

andreybokhanko retitled this revision from to Correct setting of UserLabelPrefix for MCU target.
andreybokhanko updated this object.
andreybokhanko added reviewers: rnk, mkuper.
andreybokhanko added a subscriber: cfe-commits.

Patch updated to be in line with llvm trunk. Sorry for the noise.

rafael accepted this revision.Jan 13 2016, 5:57 AM
rafael added a reviewer: rafael.
rafael added a subscriber: rafael.

LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far more common than "_".

This revision is now accepted and ready to land.Jan 13 2016, 5:57 AM

@rafael, thank you!

LGTM, but could you change the default in a followup commit? TargetInfo should really be setting it to "" since it is far more common than "_".

Sure, will do.

Yours,
Andrey

This revision was automatically updated to reflect the committed changes.