Page MenuHomePhabricator

Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam.
ClosedPublic

Authored by jlebar on Jan 8 2016, 2:06 PM.

Diff Detail

Event Timeline

jlebar updated this revision to Diff 44376.Jan 8 2016, 2:06 PM
jlebar retitled this revision from to Make Driver::BuildJobsForAction return an InputInfo, instead of using an outparam..
jlebar updated this object.
jlebar added a reviewer: echristo.
jlebar added a subscriber: llvm-commits.
echristo edited edge metadata.Jan 8 2016, 2:21 PM

One inline comment. Basic idea is that having the a "result" also be an "inputinfo" is confusing. Not that I have a better name for InputInfo, but if you come up with one...

include/clang/Driver/Driver.h
382–383

Update the comment?

jlebar marked an inline comment as done.Jan 8 2016, 3:01 PM

having the a "result" also be an "inputinfo" is confusing. Not that I have a better name for InputInfo, but if you come up with one...

Agree, I will meditate on this (for a separate patch).

jlebar updated this revision to Diff 44380.Jan 8 2016, 3:01 PM
jlebar edited edge metadata.

Address echristo's review.

echristo accepted this revision.Jan 8 2016, 3:03 PM
echristo edited edge metadata.

Thanks!

-eric

This revision is now accepted and ready to land.Jan 8 2016, 3:03 PM
jlebar added a comment.Jan 8 2016, 3:15 PM

having the a "result" also be an "inputinfo" is confusing. Not that I have a better name for InputInfo, but if you come up with one...

Agree, I will meditate on this (for a separate patch).

This revision was automatically updated to reflect the committed changes.