Page MenuHomePhabricator

Update code in buildCudaActions and BuildActions to latest idiom.
ClosedPublic

Authored by jlebar on Jan 6 2016, 1:24 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar updated this revision to Diff 44152.Jan 6 2016, 1:24 PM
jlebar retitled this revision from to Update code in buildCudaActions to latest idiom..
jlebar updated this object.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
jlebar retitled this revision from Update code in buildCudaActions to latest idiom. to Update code in buildCudaActions and BuildActions to latest idiom..Jan 6 2016, 1:29 PM
jlebar updated this revision to Diff 44155.Jan 6 2016, 1:48 PM

Fix rebase conflict.

tra accepted this revision.Jan 6 2016, 2:10 PM
tra edited edge metadata.

LGTM

lib/Driver/Driver.cpp
1300 ↗(On Diff #44155)

style nit -- no need for {}

This revision is now accepted and ready to land.Jan 6 2016, 2:10 PM
jlebar updated this revision to Diff 44158.Jan 6 2016, 2:13 PM
jlebar edited edge metadata.

Address tra's review comments.

jlebar marked an inline comment as done.Jan 6 2016, 2:15 PM
This revision was automatically updated to reflect the committed changes.