This is an archive of the discontinued LLVM Phabricator instance.

Disable shrink-wrap for Thumb1
ClosedPublic

Authored by weimingz on Jan 7 2016, 5:22 PM.

Details

Summary

In ARMConstantIslandPass, which runs after Shrink Wrap pass, long jumps will be fixed up as BL (tBfar) which depends on spilling LR in epilogue. However, shrink-wrap may remove the LR, which causes issues when the function returns.

Diff Detail

Repository
rL LLVM

Event Timeline

weimingz updated this revision to Diff 44294.Jan 7 2016, 5:22 PM
weimingz retitled this revision from to Disable shrink-wrap for Thumb1.
weimingz updated this object.
weimingz set the repository for this revision to rL LLVM.
rengolin accepted this revision.Jan 8 2016, 1:31 AM
rengolin added a reviewer: rengolin.

Shrink wrap support in Thumb is not very well tested anyway, I think it's safe to disable until proven stable.

This revision is now accepted and ready to land.Jan 8 2016, 1:31 AM
weimingz closed this revision.Jan 8 2016, 10:41 AM