This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Emit global variable sizes when targeting HSA
ClosedPublic

Authored by tstellarAMD on Jan 7 2016, 8:34 AM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Emit global variable sizes when targeting HSA.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Jan 7 2016, 10:48 AM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
156

I think you should move this cast up to the getSymbol

This revision is now accepted and ready to land.Jan 7 2016, 10:48 AM
This revision was automatically updated to reflect the committed changes.