Differential D15951

AMDGPU: Emit functions sizes
ClosedPublic
Actions

Authored by • tstellarAMD on Jan 7 2016, 8:33 AM.

Tags

None

Subscribers

arsenm, llvm-commits

Details

Reviewers

Commits

rGad8f5e811180: AMDGPU: Emit functions sizes
rL257172: AMDGPU: Emit functions sizes

Diff Detail

Repository: rL LLVM

Event Timeline

• tstellarAMD updated this revision to Diff 44216.Jan 7 2016, 8:33 AM

• tstellarAMD retitled this revision from to AMDGPU: Emit functions sizes.

• tstellarAMD updated this object.

• tstellarAMD added a reviewer: arsenm.

• tstellarAMD added a subscriber: llvm-commits.

Herald added a subscriber: arsenm. · View Herald TranscriptJan 7 2016, 8:33 AM

• tstellarAMD added a child revision: D15953: Driver: Pass -flavor gnu to lld for AMDGPU rather than -flavor gnu-old.Jan 7 2016, 8:57 AM

arsenm added inline comments.Jan 7 2016, 10:16 AM

test/CodeGen/AMDGPU/hsa.ll
31 ↗	(On Diff #44216)	Should probably have a positive check Size: {{[1-9][0-9]?}}

Add positive check for size.

LGTM

This revision is now accepted and ready to land.Jan 7 2016, 12:30 PM

Closed by commit rL257172: AMDGPU: Emit functions sizes (authored by tstellar). · Explain WhyJan 8 2016, 6:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp (1 line)
M			llvm/trunk/test/CodeGen/AMDGPU/hsa.ll (4 lines)

Diff 44323

llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp

Loading...

llvm/trunk/test/CodeGen/AMDGPU/hsa.ll

Loading...