This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Guard Cuda 12.0+ newer driver APIs with CUDA_VERSION macro checks
ClosedPublic

Authored by guraypp on Sep 5 2023, 12:05 AM.

Diff Detail

Event Timeline

guraypp created this revision.Sep 5 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2023, 12:05 AM
guraypp requested review of this revision.Sep 5 2023, 12:05 AM

This is a low tech solution to fix the problem fast in github.

If this runtime is going to be used, we perhaps need something more complex, we might add stub functions, or we check driver version using API. If we get to that point, we'll think of something more appropriate.

mehdi_amini accepted this revision.Sep 5 2023, 1:16 PM

Nit:

  • Commit title may be more descriptive as "Guard Cuda 12.0+ newer driver APIs behind CUDA_VERSION macro checks"
  • your commit message should probably say Fixes #64529 instead of "Address" so that it auto-close the issue.
  • We're using GitHub Pull-requests now :)
This revision is now accepted and ready to land.Sep 5 2023, 1:16 PM
guraypp retitled this revision from [MLIR] Use CUDA_VERSION for the driver APIs 12.0+ to [MLIR] Guard Cuda 12.0+ newer driver APIs with CUDA_VERSION macro checks.Sep 5 2023, 11:14 PM
guraypp edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Sep 5 2023, 11:17 PM
This revision was automatically updated to reflect the committed changes.