This is an archive of the discontinued LLVM Phabricator instance.

Differential D159233

[clang-format][NFC] Change duplicate config files to symlinks
AbandonedPublic

Authored by owenpan on Aug 30 2023, 3:32 PM.

Details

Reviewers
rymiel
HazardyKnusperkeks
MyDeveloperDay

Diff Detail

Event Timeline

owenpan created this revision.Aug 30 2023, 3:32 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptAug 30 2023, 3:32 PM
Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan requested review of this revision.Aug 30 2023, 3:32 PM
Harbormaster completed remote builds in B255886: Diff 554844.Aug 30 2023, 3:32 PM
HazardyKnusperkeks accepted this revision.Aug 31 2023, 2:05 AM
This revision is now accepted and ready to land.Aug 31 2023, 2:05 AM
MyDeveloperDay added a comment.Sep 1 2023, 3:05 AM

out of interest what happens on windows?

owenpan abandoned this revision.Sep 2 2023, 4:06 PM

It seems that git doesn't recreate symbolic links by default on Windows. (See e.g. clang/test/Driver/Inputs/CUDA-symlinks/usr/bin/ptxas.) I'll abandon this patch.

Revision Contents

PathSize
clang/
include/
clang/
Format/
1 line
tools/
clang-format/
1 line
unittests/
Format/
1 line

Diff 554844

clang/include/clang/Format/.clang-format

PropertyOld ValueNew Value
File Mode100644120000
../../../lib/Format/.clang-format
No newline at end of file

clang/tools/clang-format/.clang-format

PropertyOld ValueNew Value
File Mode100644120000
../../lib/Format/.clang-format
No newline at end of file

clang/unittests/Format/.clang-format

PropertyOld ValueNew Value
File Mode100644120000
../../lib/Format/.clang-format
No newline at end of file