Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159232

[libc++] Implement ranges::contains
AbandonedPublic
Actions

Authored by ZijunZhao on Wed, Aug 30, 3:18 PM.

Details

Reviewers
philnik
var-const
ldionne
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

ZijunZhao created this revision.Wed, Aug 30, 3:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 30, 3:18 PM
ZijunZhao requested review of this revision.Wed, Aug 30, 3:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 30, 3:18 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ZijunZhao added reviewers: philnik, var-const, ldionne.Wed, Aug 30, 3:19 PM
Harbormaster completed remote builds in B255885: Diff 554843.Wed, Aug 30, 3:22 PM
Mordante added a subscriber: Mordante.Wed, Aug 30, 10:58 PM

Thanks for the patch.

The LLVM project will move to GitHub PRs tomorrow. As outlined on discourse the libc++ team would like to focus on closing active reviews. It would be great if you can close this review and make a GitHub PR instead.

philnik added a comment.Thu, Aug 31, 4:37 PM

Could you abandon this, since there is a PR open on GitHub?

ZijunZhao abandoned this revision.Thu, Aug 31, 4:41 PM

Revision Contents
Changeset List

PathSize
libcxx/
include/
1 line
__algorithm/
69 lines
9 lines
1 line
test/
libcxx/
algorithms/
4 lines
1 line
std/
algorithms/
alg.nonmodifying/
alg.contains/
190 lines
library/
description/
conventions/
customization.point.object/
1 line

Diff 554843

View Options

libcxx/include/CMakeLists.txt

Loading...
View Options

libcxx/include/__algorithm/ranges_contains.h

Loading...
View Options

libcxx/include/algorithm

Loading...
View Options

libcxx/include/module.modulemap.in

Loading...
View Options

libcxx/test/libcxx/algorithms/ranges_robust_against_copying_projections.pass.cpp

Loading...
View Options

libcxx/test/libcxx/private_headers.verify.cpp

Loading...
View Options

libcxx/test/std/algorithms/alg.nonmodifying/alg.contains/ranges.contains.pass.cpp

Loading...
View Options

libcxx/test/std/library/description/conventions/customization.point.object/niebloid.compile.pass.cpp

Loading...