This is an archive of the discontinued LLVM Phabricator instance.

Differential D159197

[clang][ci] Don't block all jobs on clang-format
ClosedPublic

Authored by ldionne on Aug 30 2023, 6:23 AM.

Download Raw Diff

Details

Reviewers

aaron.ballman

Commits

rGe34ddb1b5da4: [clang][ci] Don't block all jobs on clang-format

Summary

It was expressed in some reviews that Clang folks didn't want to hold
off other testing jobs in case clang-format failed. This patch makes
it so that the basic clang testing jobs will run even if clang-format
fails on the patch. The overall build will still be marked as failed,
but it will be possible to see the failures in clang tests so at least
there will be some feedback available.

The whole pipeline was originally blocked on clang-format because we
inherited that pipeline definition from libc++, where we want to block
on clang-format for capacity reasons.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ldionne created this revision.Aug 30 2023, 6:23 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 6:23 AM

ldionne requested review of this revision.Aug 30 2023, 6:23 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 6:23 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Thank you for this! I'm not qualified to say the changes are correct (they look sensible to me though), but I am really appreciative of the change.

Harbormaster completed remote builds in B255775: Diff 554692.Aug 30 2023, 8:10 AM

In D159197#4628232, @aaron.ballman wrote:

Thank you for this! I'm not qualified to say the changes are correct (they look sensible to me though), but I am really appreciative of the change.

Yup this is mostly for awareness, the changes are simple enough and the CI run in this review shows that they worked (there's no wait step anymore after the clang-format).

This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2023, 6:53 AM

Closed by commit rGe34ddb1b5da4: [clang][ci] Don't block all jobs on clang-format (authored by ldionne). · Explain Why

This revision was automatically updated to reflect the committed changes.

ldionne added a commit: rGe34ddb1b5da4: [clang][ci] Don't block all jobs on clang-format.

Revision Contents

Path

Size

clang/

utils/

ci/

buildkite-pipeline.yml

3 lines

Diff 555029

clang/utils/ci/buildkite-pipeline.yml

	Show All 14 Lines
	#			#
	env:			env:
	# LLVM RELEASE bump version			# LLVM RELEASE bump version
	LLVM_HEAD_VERSION: "17"			LLVM_HEAD_VERSION: "17"
	steps:			steps:
	- label: "Format"			- label: "Format"
	commands:			commands:
	- "clang/utils/ci/run-buildbot check-format"			- "clang/utils/ci/run-buildbot check-format"

	agents:			agents:
	queue: "linux"			queue: "linux"
	retry:			retry:
	automatic:			automatic:
	- exit_status: -1 # Agent was lost			- exit_status: -1 # Agent was lost
	limit: 2			limit: 2
	timeout_in_minutes: 120			timeout_in_minutes: 120

	- wait

	- label: "Building and testing clang (Linux)"			- label: "Building and testing clang (Linux)"
	commands:			commands:
	- "clang/utils/ci/run-buildbot build-clang"			- "clang/utils/ci/run-buildbot build-clang"
	agents:			agents:
	queue: "linux"			queue: "linux"
	retry:			retry:
	automatic:			automatic:
	- exit_status: -1 # Agent was lost			- exit_status: -1 # Agent was lost
	▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines