This is an archive of the discontinued LLVM Phabricator instance.

Differential D159041

[msan] Fix compilation on non-glibc
ClosedPublic

Authored by brooks on Aug 28 2023, 5:07 PM.

Details

Reviewers
MaskRay
vitalybuka
mgorny
Commits
rG692344d87357: [msan] Fix compilation on non-glibc
Summary

SANITIZER_GLIBC is always defined so should be tested with an if not an
ifdef.

Fixes: ad7e2501000d

Diff Detail

Event Timeline

brooks created this revision.Aug 28 2023, 5:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 5:07 PM
Herald added a subscriber: Enna1. · View Herald Transcript
brooks requested review of this revision.Aug 28 2023, 5:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 5:07 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
brooks mentioned this in D158943: [sanitizer] Intercept glibc 2.38 __isoc23_* functions.Aug 28 2023, 5:09 PM
MaskRay accepted this revision.Aug 28 2023, 5:10 PM

Thanks!

This revision is now accepted and ready to land.Aug 28 2023, 5:10 PM
MaskRay added a comment.Aug 28 2023, 5:13 PM

Sorry for the mistake. I tested Linux x86-64, Apple M1, and Windows. FreeBSD supports msan but macOS/Windows don't support it, so the issue was not caught.

Harbormaster completed remote builds in B255354: Diff 554111.Aug 28 2023, 6:16 PM
MaskRay retitled this revision from [sanitizer] Fix compilation on non-glibc to [msan] Fix compilation on non-glibc.Aug 28 2023, 9:17 PM

Sorry, I'll commit this on your behalf to update a backport request: https://github.com/llvm/llvm-project/issues/64388.

Closed by commit rG692344d87357: [msan] Fix compilation on non-glibc (authored by brooks, committed by MaskRay). · Explain WhyAug 28 2023, 9:22 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rG692344d87357: [msan] Fix compilation on non-glibc.

Revision Contents

PathSize
compiler-rt/
lib/
msan/
2 lines

Diff 554159

compiler-rt/lib/msan/msan_interceptors.cpp

Show First 20 Lines • Show All 1,761 Lines • ▼ Show 20 Linesvoid InitializeInterceptors() {
INTERCEPT_STRTO(strtouq); INTERCEPT_STRTO(strtouq);
INTERCEPT_STRTO(wcstod); INTERCEPT_STRTO(wcstod);
INTERCEPT_STRTO(wcstof); INTERCEPT_STRTO(wcstof);
INTERCEPT_STRTO(wcstold); INTERCEPT_STRTO(wcstold);
INTERCEPT_STRTO(wcstol); INTERCEPT_STRTO(wcstol);
INTERCEPT_STRTO(wcstoul); INTERCEPT_STRTO(wcstoul);
INTERCEPT_STRTO(wcstoll); INTERCEPT_STRTO(wcstoll);
INTERCEPT_STRTO(wcstoull); INTERCEPT_STRTO(wcstoull);
#ifdef SANITIZER_GLIBC #if SANITIZER_GLIBC
INTERCEPT_STRTO(__isoc23_strtod); INTERCEPT_STRTO(__isoc23_strtod);
INTERCEPT_STRTO(__isoc23_strtof); INTERCEPT_STRTO(__isoc23_strtof);
INTERCEPT_STRTO(__isoc23_strtold); INTERCEPT_STRTO(__isoc23_strtold);
INTERCEPT_STRTO(__isoc23_strtol); INTERCEPT_STRTO(__isoc23_strtol);
INTERCEPT_STRTO(__isoc23_strtoul); INTERCEPT_STRTO(__isoc23_strtoul);
INTERCEPT_STRTO(__isoc23_strtoll); INTERCEPT_STRTO(__isoc23_strtoll);
INTERCEPT_STRTO(__isoc23_strtoull); INTERCEPT_STRTO(__isoc23_strtoull);
INTERCEPT_STRTO(__isoc23_strtouq); INTERCEPT_STRTO(__isoc23_strtouq);
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines