This is an archive of the discontinued LLVM Phabricator instance.

Differential D158951

[flang][nfc] Refine how output is defined in a test
ClosedPublic

Authored by awarzynski on Aug 27 2023, 7:17 AM.

Details

Reviewers
victorkingi
kiranchandramohan
sscalpone
Commits
rG715cde0a2558: [flang][nfc] Refine how output is defined in a test
Summary

Updates optimization-remark.f90. Makes sure that every RUN line:

  • discords the actual output of the compilation (we only care about the optimisation remarks),
  • re-uses the same definition of the output (better code re-use),
  • doesn't generate object files - no need to use -c if -emit-llvm is sufficient.

Diff Detail

Event Timeline

awarzynski created this revision.Aug 27 2023, 7:17 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptAug 27 2023, 7:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Aug 27 2023, 7:17 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 27 2023, 7:17 AM
Harbormaster completed remote builds in B255125: Diff 553790.Aug 27 2023, 7:40 AM
victorkingi accepted this revision.Aug 30 2023, 6:09 AM

LGTM

This revision is now accepted and ready to land.Aug 30 2023, 6:09 AM
This revision was landed with ongoing or failed builds.Aug 30 2023, 6:39 AM
Closed by commit rG715cde0a2558: [flang][nfc] Refine how output is defined in a test (authored by awarzynski). · Explain Why
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rG715cde0a2558: [flang][nfc] Refine how output is defined in a test.

Revision Contents

PathSize
flang/
test/
Driver/
18 lines

Diff 554696

flang/test/Driver/optimization-remark.f90

! This file tests the -Rpass family of flags (-Rpass, -Rpass-missed ! This file tests the -Rpass family of flags (-Rpass, -Rpass-missed
! and -Rpass-analysis) ! and -Rpass-analysis)
! loop-delete isn't enabled at O0 so we use at least O1 ! loop-delete isn't enabled at O0 so we use at least O1
! DEFINE: %{output} = -emit-llvm -o /dev/null 2>&1
! Check that we can override -Rpass= with -Rno-pass. ! Check that we can override -Rpass= with -Rno-pass.
! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=REMARKS ! RUN: %flang_fc1 %s -O1 -Rpass %{output} | FileCheck %s --check-prefix=REMARKS
! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=NO-REMARKS ! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass %{output} | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! Check -Rno-pass, -Rno-pass-analysis, -Rno-pass-missed nothing emitted ! Check -Rno-pass, -Rno-pass-analysis, -Rno-pass-missed nothing emitted
! RUN: %flang %s -O1 -Rno-pass -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass -S %{output} | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! RUN: %flang %s -O1 -Rno-pass-missed -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass-missed -S %{output} | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! RUN: %flang %s -O1 -Rno-pass-analysis -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass-analysis -S %{output} | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! Check full -Rpass message is emitted ! Check full -Rpass message is emitted
! RUN: %flang %s -O1 -Rpass -c 2>&1 | FileCheck %s ! RUN: %flang %s -O1 -Rpass -S %{output} | FileCheck %s
! Check full -Rpass-missed message is emitted ! Check full -Rpass-missed message is emitted
! RUN: %flang %s -O1 -Rpass-missed -c 2>&1 | FileCheck %s --check-prefix=REMARKS-MISSED ! RUN: %flang %s -O1 -Rpass-missed -S %{output} | FileCheck %s --check-prefix=REMARKS-MISSED
! Check full -Rpass-analysis message is emitted ! Check full -Rpass-analysis message is emitted
! RUN: %flang %s -O1 -Rpass-analysis -c 2>&1 | FileCheck %s --check-prefix=REMARKS-ANALYSIS ! RUN: %flang %s -O1 -Rpass-analysis -S %{output} | FileCheck %s --check-prefix=REMARKS-ANALYSIS
! CHECK: remark: Loop deleted because it is invariant ! CHECK: remark: Loop deleted because it is invariant
! REMARKS-MISSED: {{.*}} will not be inlined into {{.*}} because its definition is unavailable ! REMARKS-MISSED: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
! REMARKS-MISSED: remark: loop not vectorized ! REMARKS-MISSED: remark: loop not vectorized
! REMARKS-MISSED-NOT: loop not vectorized: instruction cannot be vectorized ! REMARKS-MISSED-NOT: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized ! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS-NOT: {{.*}} will not be inlined into {{.*}} because its definition is unavailable ! REMARKS-ANALYSIS-NOT: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
Show All 18 Lines