This is an archive of the discontinued LLVM Phabricator instance.

Differential D158934

[libc++][C++20 modules] Tests bootstrapping build.
AcceptedPublic

Authored by Mordante on Aug 26 2023, 7:34 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

Note that clang-tidy is not enabled in the bootstrap build so only
minimal testing is done for this configuration.

Diff Detail

Event Timeline

Mordante created this revision.Aug 26 2023, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2023, 7:34 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Aug 26 2023, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2023, 7:34 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B255084: Diff 553733.Aug 26 2023, 7:35 AM
ldionne accepted this revision.Sep 6 2023, 8:48 AM
ldionne added a subscriber: ldionne.

LGTM but we should have a green CI run!

libcxx/utils/ci/buildkite-pipeline.yml
351

Commit message: Tests no bootstrap build should probably be Tests bootstrapping build

This revision is now accepted and ready to land.Sep 6 2023, 8:48 AM
Mordante retitled this revision from [libc++][C++20 modules] Tests no bootstrap build. to [libc++][C++20 modules] Tests bootstrap build..Sep 6 2023, 10:49 AM
Mordante retitled this revision from [libc++][C++20 modules] Tests bootstrap build. to [libc++][C++20 modules] Tests bootstrapping build..
Mordante marked an inline comment as done.
Mordante mentioned this in D158878: [runtimes][cmake] Propagate cmake arguments..Sep 6 2023, 10:52 AM
Mordante edited the summary of this revision. (Show Details)Oct 31 2023, 12:04 PM
Mordante updated this revision to Diff 557949.Oct 31 2023, 12:32 PM

Rebased to test CI.

Harbormaster completed remote builds in B257980: Diff 557949.Oct 31 2023, 12:34 PM
Mordante removed a parent revision: D158924: [libc++][C++20 modules] Fixes CMake include paths..Oct 31 2023, 12:40 PM
Mordante updated this revision to Diff 557950.Oct 31 2023, 12:41 PM

Retrigger CI after removing the abandoned parent patch.

Harbormaster completed remote builds in B257981: Diff 557950.Oct 31 2023, 1:19 PM

Revision Contents

PathSize
libcxx/
utils/
ci/
2 lines
3 lines

Diff 557949

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 342 Lines • ▼ Show 20 Lines - label: "MSAN"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
timeout_in_minutes: 120 timeout_in_minutes: 120
# Tests with the various supported ways to build libc++. # Tests with the various supported ways to build libc++.
- label: "Bootstrapping build" - label: "Bootstrapping build"
command: "libcxx/utils/ci/run-buildbot bootstrapping-build" command: "libcxx/utils/ci/run-buildbot bootstrapping-build"
ldionneUnsubmitted
Done
ReplyInline Actions

Commit message: Tests no bootstrap build should probably be Tests bootstrapping build

ldionne: Commit message: `Tests no bootstrap build` should probably be `Tests bootstrapping build`
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
- "**/*.abilist" - "**/*.abilist"
- "**/crash_diagnostics/*" - "**/crash_diagnostics/*"
env: env:
CC: "clang-${LLVM_HEAD_VERSION}" CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}" CXX: "clang++-${LLVM_HEAD_VERSION}"
CMAKE: "/opt/bin/cmake"
ENABLE_CLANG_TIDY: "On"
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}"
CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics" CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
agents: agents:
queue: "libcxx-builders" queue: "libcxx-builders"
os: "linux" os: "linux"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
▲ Show 20 Lines • Show All 763 Lines • Show Last 20 Lines

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 366 Lines • ▼ Show 20 Lines ${CMAKE} \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
-DLLVM_ENABLE_PROJECTS="clang" \ -DLLVM_ENABLE_PROJECTS="clang" \
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \
-DLLVM_RUNTIME_TARGETS="$(${CXX} --print-target-triple)" \ -DLLVM_RUNTIME_TARGETS="$(${CXX} --print-target-triple)" \
-DLLVM_TARGETS_TO_BUILD="host" \ -DLLVM_TARGETS_TO_BUILD="host" \
-DRUNTIMES_BUILD_ALLOW_DARWIN=ON \ -DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
-DLLVM_ENABLE_ASSERTIONS=ON \ -DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests" \
-DLIBCXX_ENABLE_STD_MODULES=ON
echo "+++ Running the libc++ and libc++abi tests" echo "+++ Running the libc++ and libc++abi tests"
${NINJA} -vC "${BUILD_DIR}" check-runtimes ${NINJA} -vC "${BUILD_DIR}" check-runtimes
echo "--- Installing libc++ and libc++abi to a fake location" echo "--- Installing libc++ and libc++abi to a fake location"
${NINJA} -vC "${BUILD_DIR}" install-runtimes ${NINJA} -vC "${BUILD_DIR}" install-runtimes
ccache -s ccache -s
▲ Show 20 Lines • Show All 380 Lines • Show Last 20 Lines