[lldb] Fix TestVSCode_completions on Darwin

[JDevlieghere]

Summary

The test was expecting vector<basic_string<char>> & while the test returned vector<string> &. Since verify_completions doesn't support regex matching, sidestep the issue by using a custom type (baz).

[wallace]

Awesome!!

[JDevlieghere]

In D158893#4618503, @wallace wrote:

Awesome!!

Thank you for the prompt reviews!

lldb/test/API/tools/lldb-vscode/completions/TestVSCode_completions.py

class TestVSCode_completions(lldbvscode_testcase.VSCodeTestCaseBase):
     def verify_completions(self, actual_list, expected_list, not_expected_list=[]):
         for expected_item in expected_list:
             self.assertIn(expected_item, actual_list)
 
         for not_expected_item in not_expected_list:
             self.assertNotIn(not_expected_item, actual_list)
 
     @skipIfWindows
-    @skipIfDarwin  # Skip this test for now until we can figure out why tings aren't working on build bots
     def test_completions(self):
         """
         Tests the completion request at different breakpoints
         """
         program = self.getBuildArtifact("a.out")
         self.build_and_launch(program)
+
         source = "main.cpp"
         breakpoint1_line = line_number(source, "// breakpoint 1")
         breakpoint2_line = line_number(source, "// breakpoint 2")
-        breakpoint_ids = self.set_source_breakpoints(
-            source, [breakpoint1_line, breakpoint2_line]
-        )
+
+        self.set_source_breakpoints(source, [breakpoint1_line, breakpoint2_line])
         self.continue_to_next_stop()
 
         # shouldn't see variables inside main
         self.verify_completions(
             self.vscode.get_completions("var"),
             [
                 {
                     "text": "var",
-                    "label": "var -- vector<basic_string<char>> &",
+                    "label": "var -- vector<baz> &",
                 }
             ],
             [
                 {
                     "text": "var",
                     "label": "var -- Show variables for the current stack frame. Defaults to all arguments and local variables in scope. Names of argument, local, file static and file global variables can be specified.",
                 },
                 {"text": "var1", "label": "var1 -- int &"},
def test_completions(self):
             self.vscode.get_completions("var"),
             [
                 {"text": "var1", "label": "var1 -- int &"},
                 {"text": "var2", "label": "var2 -- int &"},
             ],
             [
                 {
                     "text": "var",
-                    "label": "var -- vector<basic_string<char>> &",
+                    "label": "var -- vector<baz> &",
                 }
             ],
         )
 
         self.verify_completions(
             self.vscode.get_completions("str"),
             [
                 {"text": "struct", "label": "struct"},

lldb/test/API/tools/lldb-vscode/completions/main.cpp

 #include <string>
 #include <vector>
 
 struct bar {
   int var1;
 };
 
 struct foo {
   int var1;
   bar* my_bar_pointer;
   bar my_bar_object;
   foo* next_foo;
 };
 
-int fun(std::vector<std::string> var) {
+struct baz {
+  char c;
+};
+
+int fun(std::vector<baz> var) {
   return var.size(); // breakpoint 1
 }
 
 int main(int argc, char const *argv[]) {
   int var1 = 0;
   int var2 = 1;
   std::string str1 = "a";
   std::string str2 = "b";
-  std::vector<std::string> vec;
+  std::vector<baz> vec;
   fun(vec);
   bar bar1 = {2};
-  bar* bar2 = &bar1; 
+  bar* bar2 = &bar1;
   foo foo1 = {3,&bar1, bar1, NULL};
   return 0; // breakpoint 2
 }