This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen][AArch64] Precommit tests for D156767 (NFC)
ClosedPublic

Authored by dhoekwater on Aug 25 2023, 11:48 AM.

Diff Detail

Event Timeline

dhoekwater created this revision.Aug 25 2023, 11:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 11:48 AM

Make sure not to remove old tests by accident

dhoekwater published this revision for review.Aug 25 2023, 12:21 PM
dhoekwater added a reviewer: mingmingl.
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 12:21 PM
mingmingl accepted this revision.Aug 28 2023, 1:15 AM
mingmingl added inline comments.
llvm/test/CodeGen/AArch64/branch-relax-cross-section.mir
195

nit: it seems attribute #0 is not used. Maybe remove it.

484–487

For my information, are 'frameInfo'/'stack' used here? If not, maybe simplify the test case a little bit. https://llvm.org/docs/MIRLangRef.html#simplifying-mir-files has some general tips; and some of them might be already applied here.

This revision is now accepted and ready to land.Aug 28 2023, 1:15 AM
dhoekwater marked 2 inline comments as done.

Simplify MIR tests

dhoekwater added inline comments.Aug 28 2023, 10:13 AM
llvm/test/CodeGen/AArch64/branch-relax-cross-section.mir
484–487

I didn't know about that document, thanks for sharing! I've applied some of the tips in it to simplify the test further.

dhoekwater added inline comments.Aug 28 2023, 10:17 AM
llvm/test/CodeGen/AArch64/branch-relax-cross-section.mir
484–487

To confirm: frameInfo/stack isn't used here. Removed.

dhoekwater updated this revision to Diff 553984.

Rebase onto head

This revision was landed with ongoing or failed builds.Aug 28 2023, 10:28 AM
This revision was automatically updated to reflect the committed changes.