This is an archive of the discontinued LLVM Phabricator instance.

[builtins] Fix undefined behavior in negdi2.c and negti2.c
ClosedPublic

Authored by Ka-Ka on Aug 24 2023, 11:42 PM.

Details

Summary

When compiling the builtins with the undefined behavior sanitizer and running testcases you end up with the following warning:

UBSan: negdi2.c:20:10: negation of -9223372036854775808 cannot be represented in type 'di_int' (aka 'long long'); cast to an unsigned type to negate this value to itself

This can be avoided by doing negation in a matching unsigned variant of the type.

The same kind of pattern is found in negti2.c

This was found in an out of tree target.

Diff Detail

Event Timeline

Ka-Ka created this revision.Aug 24 2023, 11:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 11:42 PM
Herald added a subscriber: Enna1. · View Herald Transcript
Ka-Ka requested review of this revision.Aug 24 2023, 11:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 11:42 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Aug 25 2023, 12:00 AM

Looks great!

This revision is now accepted and ready to land.Aug 25 2023, 12:00 AM
This revision was automatically updated to reflect the committed changes.