This is an archive of the discontinued LLVM Phabricator instance.

[clang-format][NFC] Remove extraneous newlines at end of test cases
ClosedPublic

Authored by owenpan on Aug 24 2023, 7:33 PM.

Details

Summary

Removes some 500 newlines (\n and \r\n) at the end of test cases in FormatTest.cpp.

Also changes a few verifyFormat() to verifyNoChange() in tests InsertNewlineAtEOF and WhitespaceSensitiveMacros as messUp() removes trailing newlines as well.

Diff Detail

Event Timeline

owenpan created this revision.Aug 24 2023, 7:33 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptAug 24 2023, 7:33 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan requested review of this revision.Aug 24 2023, 7:33 PM
clang/unittests/Format/FormatTest.cpp
24187–24188

This.

owenpan updated this revision to Diff 553600.Aug 25 2023, 1:39 PM

Addressed review comments.

owenpan marked an inline comment as done.Aug 25 2023, 1:50 PM
owenpan added inline comments.
clang/unittests/Format/FormatTest.cpp
24187–24188

Good catch! Though verifyFormat removed the newlines anyways.

owenpan edited the summary of this revision. (Show Details)Aug 25 2023, 1:53 PM
This revision is now accepted and ready to land.Aug 25 2023, 3:15 PM
owenpan edited the summary of this revision. (Show Details)Aug 25 2023, 3:32 PM
This revision was landed with ongoing or failed builds.Aug 25 2023, 3:32 PM
This revision was automatically updated to reflect the committed changes.
owenpan marked an inline comment as done.