This is an archive of the discontinued LLVM Phabricator instance.

Differential D158727

[NFC][Flang][Driver] Fix failing windows build on optimization-remark.f90
ClosedPublic

Authored by victorkingi on Aug 24 2023, 5:24 AM.

Details

Reviewers
sscalpone
awarzynski
kiranchandramohan
Commits
rG5155a75f8724: [NFC][Flang][Driver] Fix failing windows build on optimization-remark.f90
Summary

Disabled linking by adding -c flag

Diff Detail

Event Timeline

victorkingi created this revision.Aug 24 2023, 5:24 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptAug 24 2023, 5:24 AM
Herald added a reviewer: awarzynski. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
victorkingi requested review of this revision.Aug 24 2023, 5:24 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 24 2023, 5:24 AM
Harbormaster completed remote builds in B254603: Diff 553082.Aug 24 2023, 5:52 AM
kiranchandramohan accepted this revision.Aug 24 2023, 6:01 AM
kiranchandramohan added a subscriber: kiranchandramohan.

LG.

This revision is now accepted and ready to land.Aug 24 2023, 6:01 AM
Closed by commit rG5155a75f8724: [NFC][Flang][Driver] Fix failing windows build on optimization-remark.f90 (authored by Victor Kingi <victor.kingi@arm.com>). · Explain WhyAug 24 2023, 6:02 AM
This revision was automatically updated to reflect the committed changes.
Victor Kingi <victor.kingi@arm.com> added a commit: rG5155a75f8724: [NFC][Flang][Driver] Fix failing windows build on optimization-remark.f90.

Revision Contents

PathSize
flang/
test/
Driver/
12 lines

Diff 553092

flang/test/Driver/optimization-remark.f90

! This file tests the -Rpass family of flags (-Rpass, -Rpass-missed ! This file tests the -Rpass family of flags (-Rpass, -Rpass-missed
! and -Rpass-analysis) ! and -Rpass-analysis)
! loop-delete isn't enabled at O0 so we use at least O1 ! loop-delete isn't enabled at O0 so we use at least O1
! Check that we can override -Rpass= with -Rno-pass. ! Check that we can override -Rpass= with -Rno-pass.
! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=REMARKS ! RUN: %flang_fc1 %s -O1 -Rpass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=REMARKS
! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=NO-REMARKS ! RUN: %flang_fc1 %s -O1 -Rpass -Rno-pass -emit-llvm -o - 2>&1 | FileCheck %s --check-prefix=NO-REMARKS
! Check -Rno-pass, -Rno-pass-analysis, -Rno-pass-missed nothing emitted ! Check -Rno-pass, -Rno-pass-analysis, -Rno-pass-missed nothing emitted
! RUN: %flang %s -O1 -Rno-pass 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! RUN: %flang %s -O1 -Rno-pass-missed 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass-missed -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! RUN: %flang %s -O1 -Rno-pass-analysis 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS ! RUN: %flang %s -O1 -Rno-pass-analysis -c 2>&1 | FileCheck %s --allow-empty --check-prefix=NO-REMARKS
! Check full -Rpass message is emitted ! Check full -Rpass message is emitted
! RUN: %flang %s -O1 -Rpass 2>&1 | FileCheck %s ! RUN: %flang %s -O1 -Rpass -c 2>&1 | FileCheck %s
! Check full -Rpass-missed message is emitted ! Check full -Rpass-missed message is emitted
! RUN: %flang %s -O1 -Rpass-missed 2>&1 | FileCheck %s --check-prefix=REMARKS-MISSED ! RUN: %flang %s -O1 -Rpass-missed -c 2>&1 | FileCheck %s --check-prefix=REMARKS-MISSED
! Check full -Rpass-analysis message is emitted ! Check full -Rpass-analysis message is emitted
! RUN: %flang %s -O1 -Rpass-analysis 2>&1 | FileCheck %s --check-prefix=REMARKS-ANALYSIS ! RUN: %flang %s -O1 -Rpass-analysis -c 2>&1 | FileCheck %s --check-prefix=REMARKS-ANALYSIS
! CHECK: remark: Loop deleted because it is invariant ! CHECK: remark: Loop deleted because it is invariant
! REMARKS-MISSED: {{.*}} will not be inlined into {{.*}} because its definition is unavailable ! REMARKS-MISSED: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
! REMARKS-MISSED: remark: loop not vectorized ! REMARKS-MISSED: remark: loop not vectorized
! REMARKS-MISSED-NOT: loop not vectorized: instruction cannot be vectorized ! REMARKS-MISSED-NOT: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized ! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS-NOT: {{.*}} will not be inlined into {{.*}} because its definition is unavailable ! REMARKS-ANALYSIS-NOT: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
Show All 18 Lines