This is an archive of the discontinued LLVM Phabricator instance.

[lldb/crashlog] Fix python version requirement issue
ClosedPublic

Authored by mib on Aug 21 2023, 1:32 PM.

Details

Summary

In 21a597c, we fixed a module loading issue by using the new
argparse.BooleanOptionalAction. However, this is only available
starting python 3.9 and causes test failures on bots that don't fulfill
this requirement.

To address that, this patch replaces the use of BooleanOptionalAction
by a pair of 2 opposite store actions pointing to the same destination
variable.

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>

Diff Detail

Event Timeline

mib created this revision.Aug 21 2023, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 1:32 PM
mib requested review of this revision.Aug 21 2023, 1:32 PM
bulbazord accepted this revision.Aug 21 2023, 1:33 PM

Unfortunate but it makes the most sense for now. Thanks for fixing that.

This revision is now accepted and ready to land.Aug 21 2023, 1:33 PM
This revision was automatically updated to reflect the committed changes.