Fixing the memory leak using split() instead of strtok

[hchilama]

Using the split() instead of strtok to improve the performance

[abhina.sreeskantharajan]

LGTM!

[abhina.sreeskantharajan]

It seems like clang-format might be failing with this patch which should be fixed first.

And I think I cannot actually accept this patch because I see the following hchilama created this object with edit policy "Administrators".

[hchilama]

Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format, seems fine. (FYI: I saw clean build on Friday)

I have modified this object with the edit policy "All Users"

Please let me know if I need to do anything else here?

[abhina.sreeskantharajan]

In D158254#4603765, @hchilama wrote:

Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format, seems fine. (FYI: I saw clean build on Friday)

I have modified this object with the edit policy "All Users"

Please let me know if I need to do anything else here?

I think the format should be good then, the CI might be failing due to another commit. LGTM, thanks!

[hchilama]

Hi @abhina.sreeskantharajan can I please know the next process on how to land this revision to opensource?

[abhina.sreeskantharajan]

In D158254#4605050, @hchilama wrote:

Hi @abhina.sreeskantharajan can I please know the next process on how to land this revision to opensource?

Usually you need to have someone with commit access commit the changes for you for your first couple of patches and then you can request commit access yourself. This is outlined here https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
I'd be happy to commit this patch for you if needed :)

[hchilama]

Hi @abhina.sreeskantharajan , Thanks for letting me know the process and please help me in commiting this patch.

[abhina.sreeskantharajan]

In D158254#4607027, @hchilama wrote:

Hi @abhina.sreeskantharajan , Thanks for letting me know the process and please help me in commiting this patch.

I'd like to put your name and email as the commit's author. What email should I use? git commit --amend --author="Harini Chilamantula <[e-mail]>"

[hchilama]

Please use my Intel email Chilamantula, Harini <[e-mail]> .

clang/lib/Driver/ToolChains/ZOS.cpp

void zos::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs)) {
     ld_env_var = StringRef(getenv("_LD_SIDE_DECKS")).trim();
     if (ld_env_var.empty()) {
       CmdArgs.push_back(
           Args.MakeArgString("//'" + LEHLQ + ".SCEELIB(CELQS001)'"));
       CmdArgs.push_back(
           Args.MakeArgString("//'" + LEHLQ + ".SCEELIB(CELQS003)'"));
     } else {
-      char *ld_side_deck = strdup(ld_env_var.str().c_str());
-      ld_side_deck = strtok(ld_side_deck, ":");
-      while (ld_side_deck != nullptr) {
-        CmdArgs.push_back(ld_side_deck);
-        ld_side_deck = strtok(nullptr, ":");
+      SmallVector<StringRef> ld_side_deck;
+      ld_env_var.split(ld_side_deck, ":");
+      for (StringRef ld_loc : ld_side_deck) {
+        CmdArgs.push_back((ld_loc.str()).c_str());
       }
     }
   }
   // Link libc++ library
   if (ToolChain.ShouldLinkCXXStdlib(Args)) {
     ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
   }