This is an archive of the discontinued LLVM Phabricator instance.

[libc++][Modules] Simplify the __std_clang_module header generation
ClosedPublic

Authored by iana on Aug 16 2023, 5:03 PM.

Details

Summary

Post review feedback on D157364. Don't section the __std_clang_module header by macro, put the headers in alphabetical order and repeat the macro guards. Restore header_information.header_restrictions.

Diff Detail

Event Timeline

iana created this revision.Aug 16 2023, 5:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 5:03 PM
iana requested review of this revision.Aug 16 2023, 5:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 5:03 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 17 2023, 6:42 AM
This revision is now accepted and ready to land.Aug 17 2023, 6:42 AM

LGTM with green CI.

iana updated this revision to Diff 551203.Aug 17 2023, 11:29 AM

Fix the formatting

iana updated this revision to Diff 551205.Aug 17 2023, 11:31 AM

Regenerate the header