This is an archive of the discontinued LLVM Phabricator instance.

Differential D158106

[flang][openacc] Attach attribute only when there is an exit operation
ClosedPublic

Authored by clementval on Aug 16 2023, 12:01 PM.

Details

Reviewers
razvanlupusoru
vzakhari
Commits
rG939bdaec18c9: [flang][openacc] Attach attribute only when there is an exit operation
Summary

Not all declare clause have an exit operation attach to them and
therefore no dealloc function generated. Attach
the pre/post deallocation attribute only for the clauses that have
an exit operation.

Diff Detail

Event Timeline

clementval created this revision.Aug 16 2023, 12:01 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 16 2023, 12:01 PM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Aug 16 2023, 12:01 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 16 2023, 12:01 PM
razvanlupusoru accepted this revision.Aug 16 2023, 12:23 PM

Thank you!

This revision is now accepted and ready to land.Aug 16 2023, 12:23 PM
This revision was landed with ongoing or failed builds.Aug 16 2023, 1:10 PM
Closed by commit rG939bdaec18c9: [flang][openacc] Attach attribute only when there is an exit operation (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG939bdaec18c9: [flang][openacc] Attach attribute only when there is an exit operation.
Harbormaster completed remote builds in B253009: Diff 550836.Aug 16 2023, 1:15 PM

Revision Contents

PathSize
flang/
lib/
Lower/
16 lines

Diff 550853

flang/lib/Lower/OpenACC.cpp

Show First 20 Lines • Show All 3,042 Lines • ▼ Show 20 Lines op.setAttr(mlir::acc::getDeclareActionAttrName(),
/*preAlloc=*/{}, /*preAlloc=*/{},
/*postAlloc=*/builder.getSymbolRefAttr(fctName.str()), /*postAlloc=*/builder.getSymbolRefAttr(fctName.str()),
/*preDealloc=*/{}, /*postDealloc=*/{})); /*preDealloc=*/{}, /*postDealloc=*/{}));
} }
void Fortran::lower::attachDeclarePreDeallocAction( void Fortran::lower::attachDeclarePreDeallocAction(
AbstractConverter &converter, fir::FirOpBuilder &builder, AbstractConverter &converter, fir::FirOpBuilder &builder,
mlir::Value beginOpValue, const Fortran::semantics::Symbol &sym) { mlir::Value beginOpValue, const Fortran::semantics::Symbol &sym) {
if (!sym.test(Fortran::semantics::Symbol::Flag::AccCreate) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyIn) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyInReadOnly) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopy) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyOut) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccDeviceResident))
return;
std::stringstream fctName; std::stringstream fctName;
fctName << converter.mangleName(sym) << declarePreDeallocSuffix.str(); fctName << converter.mangleName(sym) << declarePreDeallocSuffix.str();
beginOpValue.getDefiningOp()->setAttr( beginOpValue.getDefiningOp()->setAttr(
mlir::acc::getDeclareActionAttrName(), mlir::acc::getDeclareActionAttrName(),
mlir::acc::DeclareActionAttr::get( mlir::acc::DeclareActionAttr::get(
builder.getContext(), builder.getContext(),
/*preAlloc=*/{}, /*postAlloc=*/{}, /*preAlloc=*/{}, /*postAlloc=*/{},
/*preDealloc=*/builder.getSymbolRefAttr(fctName.str()), /*preDealloc=*/builder.getSymbolRefAttr(fctName.str()),
/*postDealloc=*/{})); /*postDealloc=*/{}));
} }
void Fortran::lower::attachDeclarePostDeallocAction( void Fortran::lower::attachDeclarePostDeallocAction(
AbstractConverter &converter, fir::FirOpBuilder &builder, AbstractConverter &converter, fir::FirOpBuilder &builder,
const Fortran::semantics::Symbol &sym) { const Fortran::semantics::Symbol &sym) {
if (!sym.test(Fortran::semantics::Symbol::Flag::AccCreate) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyIn) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyInReadOnly) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopy) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccCopyOut) &&
!sym.test(Fortran::semantics::Symbol::Flag::AccDeviceResident))
return;
std::stringstream fctName; std::stringstream fctName;
fctName << converter.mangleName(sym) << declarePostDeallocSuffix.str(); fctName << converter.mangleName(sym) << declarePostDeallocSuffix.str();
mlir::Operation &op = builder.getInsertionBlock()->back(); mlir::Operation &op = builder.getInsertionBlock()->back();
op.setAttr(mlir::acc::getDeclareActionAttrName(), op.setAttr(mlir::acc::getDeclareActionAttrName(),
mlir::acc::DeclareActionAttr::get( mlir::acc::DeclareActionAttr::get(
builder.getContext(), builder.getContext(),
/*preAlloc=*/{}, /*postAlloc=*/{}, /*preDealloc=*/{}, /*preAlloc=*/{}, /*postAlloc=*/{}, /*preDealloc=*/{},
/*postDealloc=*/builder.getSymbolRefAttr(fctName.str()))); /*postDealloc=*/builder.getSymbolRefAttr(fctName.str())));
} }