[TextAPI] Make sortTargetValues strict weak ordering compliant

[danlark]

Summary

Second sorting was not following strict weak ordering as it
does not follow transitivity of equivalence property.

If you build llvm with libcxx at head as a standard library with -D_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK and -D_LIBCPP_ENABLE_DEBUG_MODE, then tests like llvm/test/tools/llvm-readtapi/compare-right-single-inline.test.test will fail

I don't have commit rights. Danila Kutenin [e-mail]

[cishida]

LGTM, thanks!

I don't have commit rights

I'll commit this for you on main.

llvm/tools/llvm-readtapi/DiffEngine.cpp

 template <typename T>
 T *castValues(const std::unique_ptr<AttributeDiff> &RawAttr) {
   T *CastAttr = cast<T>(RawAttr.get());
   return CastAttr;
 }
 
 template <typename T> void sortTargetValues(std::vector<T> &TargValues) {
   llvm::stable_sort(TargValues, [](const auto &ValA, const auto &ValB) {
+    if (ValA.getOrder() == ValB.getOrder()) {
+      return ValA.getVal() < ValB.getVal();
+    }
     return ValA.getOrder() < ValB.getOrder();
   });
-  llvm::stable_sort(TargValues, [](const auto &ValA, const auto &ValB) {
-    return ValA.getOrder() == ValB.getOrder() && ValA.getVal() < ValB.getVal();
-  });
 }
 
 template <typename T>
 void printVecVal(std::string Indent, const DiffOutput &Attr, raw_ostream &OS) {
   if (Attr.Values.empty())
     return;
 
   OS << Indent << Attr.Name << "\n";