This is an archive of the discontinued LLVM Phabricator instance.

Differential D15794

CheckerContext::isCLibraryFunction(): small refactoring; NFC
ClosedPublic

Authored by a.sidorin on Dec 28 2015, 7:26 AM.

Details

Reviewers
dcoughlin
zaks.anna
xazax.hun
Commits
rGbe4b2b72b1bc: Small refactoring in CheckerContext::isCLibraryFunction(). NFC.
rC256524: Small refactoring in CheckerContext::isCLibraryFunction(). NFC.
rL256524: Small refactoring in CheckerContext::isCLibraryFunction(). NFC.
Summary

Use getRedeclContext() instead of a manually written loop; fix a comment.

Diff Detail

Repository
rL LLVM

Event Timeline

a.sidorin updated this revision to Diff 43688.Dec 28 2015, 7:26 AM
a.sidorin retitled this revision from to CheckerContext::isCLibraryFunction(): small refactoring; NFC.
a.sidorin updated this object.
a.sidorin added reviewers: zaks.anna, xazax.hun, dcoughlin.
a.sidorin set the repository for this revision to rL LLVM.
a.sidorin added a subscriber: cfe-commits.
dcoughlin accepted this revision.Dec 28 2015, 1:48 PM
dcoughlin edited edge metadata.

LGTM. I'll commit. Thanks Aleksei!

This revision is now accepted and ready to land.Dec 28 2015, 1:48 PM
Closed by commit rL256524: Small refactoring in CheckerContext::isCLibraryFunction(). NFC. (authored by dcoughlin). · Explain WhyDec 28 2015, 1:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
StaticAnalyzer/
Core/
8 lines

Diff 43706

cfe/trunk/lib/StaticAnalyzer/Core/CheckerContext.cpp

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesbool CheckerContext::isCLibraryFunction(const FunctionDecl *FD,
const IdentifierInfo *II = FD->getIdentifier(); const IdentifierInfo *II = FD->getIdentifier();
// If this is a special C++ name without IdentifierInfo, it can't be a // If this is a special C++ name without IdentifierInfo, it can't be a
// C library function. // C library function.
if (!II) if (!II)
return false; return false;
// Look through 'extern "C"' and anything similar invented in the future. // Look through 'extern "C"' and anything similar invented in the future.
const DeclContext *DC = FD->getDeclContext(); // If this function is not in TU directly, it is not a C library function.
while (DC->isTransparentContext()) if (!FD->getDeclContext()->getRedeclContext()->isTranslationUnit())
DC = DC->getParent();
// If this function is in a namespace, it is not a C library function.
if (!DC->isTranslationUnit())
return false; return false;
// If this function is not externally visible, it is not a C library function. // If this function is not externally visible, it is not a C library function.
// Note that we make an exception for inline functions, which may be // Note that we make an exception for inline functions, which may be
// declared in header files without external linkage. // declared in header files without external linkage.
if (!FD->isInlined() && !FD->isExternallyVisible()) if (!FD->isInlined() && !FD->isExternallyVisible())
return false; return false;
Show All 25 Lines