This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fix ClangScanDeps test for #61006.
ClosedPublic

Authored by ingomueller-net on Aug 13 2023, 10:59 AM.

Details

Summary

This patch solves two problems with the recently added test, which
caused CI failure in an internal downstream system:

  1. It connects subsequent RUN statements with && into a single statement; otherwise, the variable defined in the first of them is out of scope in the subsequent ones where it is used.
  2. In our hermetic testing environment, the clang++ binary under test does not have access to standard include paths (/usr/include etc.), so the test fails because it does not find stddef.h. The patch thus changes the test to use a locally created a.h header file.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2023, 10:59 AM
ingomueller-net requested review of this revision.Aug 13 2023, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2023, 10:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2023, 11:23 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.