This is an archive of the discontinued LLVM Phabricator instance.

Differential D157779

[libc++][CI] Removes an ASAN work-around.
ClosedPublic

Authored by Mordante on Aug 12 2023, 6:21 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGb22253b7715e: [libc++][CI] Removes an ASAN work-around.
Summary

With the underlying bug fixed the work-around should no longer be
needed.

Diff Detail

Event Timeline

Mordante created this revision.Aug 12 2023, 6:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 6:21 AM
Mordante requested review of this revision.Aug 12 2023, 6:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 6:21 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B252104: Diff 549606.Aug 12 2023, 1:20 PM
philnik accepted this revision.Aug 14 2023, 5:09 PM
This revision is now accepted and ready to land.Aug 14 2023, 5:09 PM
This revision was landed with ongoing or failed builds.Aug 15 2023, 10:14 AM
Closed by commit rGb22253b7715e: [libc++][CI] Removes an ASAN work-around. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGb22253b7715e: [libc++][CI] Removes an ASAN work-around..
ldionne mentioned this in D120816: [libc++] Remove workaround for google/sanitizers#1017.Sep 1 2023, 8:30 AM

Revision Contents

PathSize
libcxx/
cmake/
caches/
2 lines

Diff 550380

libcxx/cmake/caches/Generic-asan.cmake

set(LLVM_USE_SANITIZER "Address" CACHE STRING "") set(LLVM_USE_SANITIZER "Address" CACHE STRING "")
# This is a temporary (hopefully) workaround for an ASan issue (see https://llvm.org/D119410).
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mllvm -asan-use-private-alias=1" CACHE INTERNAL "")