This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove workaround for google/sanitizers#1017
AbandonedPublic

Authored by ldionne on Mar 2 2022, 7:37 AM.

Reviewers

None

Group Reviewers

Restricted Project

Summary

I can't seem to reproduce the issue locally, so I think this is good to
remove. If not, CI will tell.

	Time	Test
	2,420 ms	libcxx CI ASAN > llvm-libc++-shared-cfg-in.std/utilities/function_objects/func_wrap/func_wrap_badcall/func_wrap_badcall_const::bad_function_call_ctor.pass.cpp
	2,750 ms	libcxx CI ASAN > llvm-libc++-shared-cfg-in.std/utilities/function_objects/func_wrap/func_wrap_func::addressof.pass.cpp
	7,880 ms	libcxx CI ASAN > llvm-libc++-shared-cfg-in.std/utilities/function_objects/func_wrap/func_wrap_func::noncopyable_return_type.pass.cpp
	3,560 ms	libcxx CI ASAN > llvm-libc++-shared-cfg-in.std/utilities/function_objects/func_wrap/func_wrap_func/func_wrap_func_con::F_assign.pass.cpp
	2,830 ms	libcxx CI ASAN > llvm-libc++-shared-cfg-in.std/utilities/function_objects/func_wrap/func_wrap_func/func_wrap_func_con::F_incomplete.pass.cpp
		View Full Test Results (6 Failed)

ldionne requested review of this revision.Mar 2 2022, 7:37 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Well, I'll be damned. I'll need to work harder on my local reproducer 😭

This was removed by D157779.

Path

Size

libcxx/

cmake/

caches/

2 lines

	set(LLVM_USE_SANITIZER "Address" CACHE STRING "")			set(LLVM_USE_SANITIZER "Address" CACHE STRING "")
	# This is a temporary (hopefully) workaround for an ASan issue (see https://llvm.org/D119410).
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mllvm -asan-use-private-alias=1" CACHE INTERNAL "")