This is an archive of the discontinued LLVM Phabricator instance.

[InstSimplify] Add more tests for simplifying `(icmp ugt/ule (or X, Y), X)`; NFC
AbandonedPublic

Authored by goldstein.w.n on Aug 11 2023, 1:19 PM.

Download Raw Diff

Details

Reviewers

nikic
Allen

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60,040 ms	x64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

goldstein.w.n created this revision.Aug 11 2023, 1:19 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 1:19 PM

Herald added a subscriber: StephenFan. · View Herald Transcript

goldstein.w.n requested review of this revision.Aug 11 2023, 1:19 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2023, 1:19 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

goldstein.w.n added a child revision: D157755: [InstSimplify] Use knownbits for simplifying `(icmp ugt/ule (or X, Y), X)`; PR64610.Aug 11 2023, 1:19 PM

Harbormaster completed remote builds in B252039: Diff 549509.Aug 11 2023, 3:02 PM

nikic added inline comments.Aug 12 2023, 6:55 AM

llvm/test/Transforms/InstSimplify/icmp-orx-x.ll
110	Convert to param.
114	Drop the control flow.

Cleanup repro test.
Add tests with some common bits

goldstein.w.n marked 2 inline comments as done.Aug 12 2023, 10:46 AM

LGTM

This revision is now accepted and ready to land.Aug 12 2023, 10:53 AM

Harbormaster completed remote builds in B252127: Diff 549632.Aug 12 2023, 11:11 AM

Rebase

Harbormaster completed remote builds in B252133: Diff 549640.Aug 12 2023, 2:39 PM

I'm going to push these tests and abandon the impl.

Actually nvm

I'm going to add these tests for the new series.

Revision Contents

Path

Size

llvm/

test/

Transforms/

InstSimplify/

icmp-orx-x.ll

123 lines

Diff 549509

llvm/test/Transforms/InstSimplify/icmp-orx-x.ll

This file was added.

				; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
				; RUN: opt < %s -passes=instsimplify -S \| FileCheck %s

				define i1 @or_simplify_ule(i8 %y_in, i8 %rhs_in, i1 %c) {
				; CHECK-LABEL: @or_simplify_ule(
				; CHECK-NEXT: [[Y:%.]] = or i8 [[Y_IN:%.]], 1
				; CHECK-NEXT: [[RHS:%.]] = and i8 [[RHS_IN:%.]], -2
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[LBO]], [[RHS]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = or i8 %y_in, 1
				%rhs = and i8 %rhs_in, -2
				%lbo = or i8 %y, %rhs
				%r = icmp ule i8 %lbo, %rhs
				ret i1 %r
				}

				define i1 @or_simplify_uge(i8 %y_in, i8 %rhs_in, i1 %c) {
				; CHECK-LABEL: @or_simplify_uge(
				; CHECK-NEXT: [[Y:%.]] = or i8 [[Y_IN:%.]], -128
				; CHECK-NEXT: [[RHS:%.]] = and i8 [[RHS_IN:%.]], 127
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp uge i8 [[RHS]], [[LBO]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = or i8 %y_in, 128
				%rhs = and i8 %rhs_in, 127
				%lbo = or i8 %y, %rhs
				%r = icmp uge i8 %rhs, %lbo
				ret i1 %r
				}

				define i1 @or_simplify_ule_fail(i8 %y_in, i8 %rhs_in) {
				; CHECK-LABEL: @or_simplify_ule_fail(
				; CHECK-NEXT: [[Y:%.]] = or i8 [[Y_IN:%.]], 64
				; CHECK-NEXT: [[RHS:%.]] = and i8 [[RHS_IN:%.]], 127
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp ule i8 [[LBO]], [[RHS]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = or i8 %y_in, 64
				%rhs = and i8 %rhs_in, 127
				%lbo = or i8 %y, %rhs
				%r = icmp ule i8 %lbo, %rhs
				ret i1 %r
				}

				define i1 @or_simplify_ugt(i8 %y_in, i8 %rhs_in) {
				; CHECK-LABEL: @or_simplify_ugt(
				; CHECK-NEXT: [[Y:%.]] = or i8 [[Y_IN:%.]], 1
				; CHECK-NEXT: [[RHS:%.]] = and i8 [[RHS_IN:%.]], -2
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[LBO]], [[RHS]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = or i8 %y_in, 1
				%rhs = and i8 %rhs_in, -2
				%lbo = or i8 %y, %rhs
				%r = icmp ugt i8 %lbo, %rhs
				ret i1 %r
				}

				define i1 @or_simplify_ult(i8 %y_in, i8 %rhs_in) {
				; CHECK-LABEL: @or_simplify_ult(
				; CHECK-NEXT: [[Y:%.]] = or i8 [[Y_IN:%.]], 4
				; CHECK-NEXT: [[RHS:%.]] = and i8 [[RHS_IN:%.]], -5
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[RHS]], [[LBO]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = or i8 %y_in, 4
				%rhs = and i8 %rhs_in, -5
				%lbo = or i8 %y, %rhs
				%r = icmp ult i8 %rhs, %lbo
				ret i1 %r
				}

				define i1 @or_simplify_ugt_fail(i8 %y_in, i8 %rhs_in) {
				; CHECK-LABEL: @or_simplify_ugt_fail(
				; CHECK-NEXT: [[Y:%.]] = and i8 [[Y_IN:%.]], -2
				; CHECK-NEXT: [[RHS:%.]] = or i8 [[RHS_IN:%.]], 1
				; CHECK-NEXT: [[LBO:%.*]] = or i8 [[Y]], [[RHS]]
				; CHECK-NEXT: [[R:%.*]] = icmp ugt i8 [[LBO]], [[RHS]]
				; CHECK-NEXT: ret i1 [[R]]
				;
				%y = and i8 %y_in, -2
				%rhs = or i8 %rhs_in, 1
				%lbo = or i8 %y, %rhs
				%r = icmp ugt i8 %lbo, %rhs
				ret i1 %r
				}

				@b = internal unnamed_addr global i1 false, align 2
				declare void @foo()
				define i32 @pr64610() {
				; CHECK-LABEL: @pr64610(
				; CHECK-NEXT: [[TMP1:%.*]] = load i1, ptr @b, align 2
				; CHECK-NEXT: [[TMP2:%.*]] = select i1 [[TMP1]], i32 74, i32 0
				; CHECK-NEXT: [[TMP3:%.*]] = or i32 [[TMP2]], 1
				; CHECK-NEXT: [[TMP4:%.*]] = icmp ugt i32 [[TMP3]], [[TMP2]]
				; CHECK-NEXT: br i1 [[TMP4]], label [[TMP6:%.]], label [[TMP5:%.]]
				; CHECK: 5:
				; CHECK-NEXT: tail call void @foo()
				; CHECK-NEXT: br label [[TMP6]]
				; CHECK: 6:
				; CHECK-NEXT: store i1 true, ptr @b, align 2
				; CHECK-NEXT: ret i32 0
				;
				%1 = load i1, ptr @b, align 2
				nikicUnsubmitted Done Reply Inline Actions Convert to param. nikic: Convert to param.
				%2 = select i1 %1, i32 74, i32 0
				%3 = or i32 %2, 1
				%4 = icmp ugt i32 %3, %2
				br i1 %4, label %6, label %5
				nikicUnsubmitted Done Reply Inline Actions Drop the control flow. nikic: Drop the control flow.

				5:
				tail call void @foo()
				br label %6

				6:
				store i1 true, ptr @b, align 2
				ret i32 0
				}