This is an archive of the discontinued LLVM Phabricator instance.

Differential D157665

[InstrProf] Fix debug-info-correlate test
ClosedPublic

Authored by ellis on Aug 10 2023, 5:04 PM.

Details

Reviewers
gulfem
MaskRay
zequanwu
Commits
rGcd861ad0f94d: [InstrProf] Fix debug-info-correlate test
Summary

The llvm-profdata show command is not sufficient to check that two
profiles are identical because it doesn't show the counter values. Add
the flags --all-functions --counts so that counter values are checked.

This was changed in https://reviews.llvm.org/D135929 but I failed to
remember that counter values were not printed by default.

Diff Detail

Event Timeline

ellis created this revision.Aug 10 2023, 5:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 5:04 PM
Herald added a subscriber: Enna1. · View Herald Transcript
ellis requested review of this revision.Aug 10 2023, 5:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 5:04 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ellis added reviewers: gulfem, MaskRay, zequanwu.Aug 10 2023, 5:04 PM
Harbormaster completed remote builds in B251809: Diff 549202.Aug 10 2023, 5:18 PM
MaskRay accepted this revision.Aug 10 2023, 9:42 PM
This revision is now accepted and ready to land.Aug 10 2023, 9:42 PM
zequanwu added a comment.Aug 11 2023, 8:25 AM

I noticed that the profdata files are compared with just diff in compiler-rt/test/profile/Darwin/instrprof-debug-info-correlate.c. Can we do the same here?

ellis updated this revision to Diff 549435.Aug 11 2023, 9:17 AM

Update the Darwin test too

This revision was landed with ongoing or failed builds.Aug 11 2023, 9:20 AM
Closed by commit rGcd861ad0f94d: [InstrProf] Fix debug-info-correlate test (authored by ellis). · Explain Why
This revision was automatically updated to reflect the committed changes.
ellis added a commit: rGcd861ad0f94d: [InstrProf] Fix debug-info-correlate test.
Harbormaster completed remote builds in B251988: Diff 549435.Aug 11 2023, 9:32 AM

Revision Contents

PathSize
compiler-rt/
test/
profile/
Linux/
6 lines

Diff 549202

compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c

// Value profiling is currently not supported in lightweight mode. // Value profiling is currently not supported in lightweight mode.
// RUN: %clang_pgogen -o %t.normal -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp // RUN: %clang_pgogen -o %t.normal -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t.normal // RUN: env LLVM_PROFILE_FILE=%t.profraw %run %t.normal
// RUN: llvm-profdata merge -o %t.normal.profdata %t.profraw // RUN: llvm-profdata merge -o %t.normal.profdata %t.profraw
// RUN: %clang_pgogen -o %t.d4 -g -gdwarf-4 -mllvm --debug-info-correlate -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp // RUN: %clang_pgogen -o %t.d4 -g -gdwarf-4 -mllvm --debug-info-correlate -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: env LLVM_PROFILE_FILE=%t.d4.proflite %run %t.d4 // RUN: env LLVM_PROFILE_FILE=%t.d4.proflite %run %t.d4
// RUN: llvm-profdata merge -o %t.d4.profdata --debug-info=%t.d4 %t.d4.proflite // RUN: llvm-profdata merge -o %t.d4.profdata --debug-info=%t.d4 %t.d4.proflite
// RUN: diff <(llvm-profdata show %t.normal.profdata) <(llvm-profdata show %t.d4.profdata) // RUN: diff <(llvm-profdata show --all-functions --counts %t.normal.profdata) <(llvm-profdata show --all-functions --counts %t.d4.profdata)
// RUN: %clang_pgogen -o %t -g -mllvm --debug-info-correlate -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp // RUN: %clang_pgogen -o %t -g -mllvm --debug-info-correlate -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: env LLVM_PROFILE_FILE=%t.proflite %run %t // RUN: env LLVM_PROFILE_FILE=%t.proflite %run %t
// RUN: llvm-profdata merge -o %t.profdata --debug-info=%t %t.proflite // RUN: llvm-profdata merge -o %t.profdata --debug-info=%t %t.proflite
// RUN: diff <(llvm-profdata show %t.normal.profdata) <(llvm-profdata show %t.profdata) // RUN: diff <(llvm-profdata show --all-functions --counts %t.normal.profdata) <(llvm-profdata show --all-functions --counts %t.profdata)
// RUN: %clang_pgogen -o %t.cov -g -mllvm --debug-info-correlate -mllvm -pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp // RUN: %clang_pgogen -o %t.cov -g -mllvm --debug-info-correlate -mllvm -pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: env LLVM_PROFILE_FILE=%t.cov.proflite %run %t.cov // RUN: env LLVM_PROFILE_FILE=%t.cov.proflite %run %t.cov
// RUN: llvm-profdata merge -o %t.cov.profdata --debug-info=%t.cov %t.cov.proflite // RUN: llvm-profdata merge -o %t.cov.profdata --debug-info=%t.cov %t.cov.proflite
// RUN: %clang_pgogen -o %t.cov.normal -mllvm --pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp // RUN: %clang_pgogen -o %t.cov.normal -mllvm --pgo-function-entry-coverage -mllvm --disable-vp=true %S/../Inputs/instrprof-debug-info-correlate-main.cpp %S/../Inputs/instrprof-debug-info-correlate-foo.cpp
// RUN: env LLVM_PROFILE_FILE=%t.cov.profraw %run %t.cov.normal // RUN: env LLVM_PROFILE_FILE=%t.cov.profraw %run %t.cov.normal
// RUN: llvm-profdata merge -o %t.cov.normal.profdata %t.cov.profraw // RUN: llvm-profdata merge -o %t.cov.normal.profdata %t.cov.profraw
// RUN: diff <(llvm-profdata show %t.cov.normal.profdata) <(llvm-profdata show %t.cov.profdata) // RUN: diff <(llvm-profdata show --all-functions --counts %t.cov.normal.profdata) <(llvm-profdata show --all-functions --counts %t.cov.profdata)