This is an archive of the discontinued LLVM Phabricator instance.

[InstrProf] Report error when merging temporal profiles
ClosedPublic

Authored by ellis on Aug 10 2023, 4:43 PM.

Details

Summary

Temporal profiles do not support profile merging at runtime. The reason
is that each function can only store one timestamp and the
llmv-profdata tool is responsible for sampling traces during the merge
command. Report an error in __llvm_profile_merge_from_buffer() if
merging a temporal profile.

The added test also checks that lightweight profiles throw an error,
although this may be fixed in https://reviews.llvm.org/D157632

Diff Detail

Event Timeline

ellis created this revision.Aug 10 2023, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 4:43 PM
Herald added a subscriber: Enna1. · View Herald Transcript
ellis requested review of this revision.Aug 10 2023, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2023, 4:43 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
zequanwu accepted this revision.Aug 11 2023, 8:03 AM

LGTM.

This revision is now accepted and ready to land.Aug 11 2023, 8:03 AM
MaskRay accepted this revision.Aug 11 2023, 8:06 AM
This revision was automatically updated to reflect the committed changes.