This is an archive of the discontinued LLVM Phabricator instance.

[clang-repl] Additional test for disambiguation of templates
ClosedPublic

Authored by Hahnfeld on Aug 8 2023, 11:57 PM.

Details

Summary

This test case was fixed in commit rG2c4620c1 ("Consider the scope spec in template lookups for deduction guides."), but it is worth having a dedicated test case with a templated struct and a using declaration.

Diff Detail

Event Timeline

Hahnfeld created this revision.Aug 8 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 11:57 PM
Hahnfeld requested review of this revision.Aug 8 2023, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 11:57 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.Aug 9 2023, 1:15 AM

If you have not merged this patch please consider my comment.

clang/test/Interpreter/namespace-template-disambiguate.cpp
7 ↗(On Diff #548481)

It might be a good idea to add this test to disambiguate-decl-stmt.cpp where we track these things.

Hahnfeld updated this revision to Diff 548558.Aug 9 2023, 4:29 AM
Hahnfeld retitled this revision from [clang-repl] Add test for disambiguation of templates to [clang-repl] Additional test for disambiguation of templates.
Hahnfeld edited the summary of this revision. (Show Details)
Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.
clang/test/Interpreter/namespace-template-disambiguate.cpp
7 ↗(On Diff #548481)

done

v.g.vassilev accepted this revision.Aug 9 2023, 4:49 AM
This revision was landed with ongoing or failed builds.Aug 9 2023, 7:15 AM
This revision was automatically updated to reflect the committed changes.