This is an archive of the discontinued LLVM Phabricator instance.

Differential D157446

[libc++] Use _LIBCPP_VERBOSE_ABORT from __throw_bad_alloc
ClosedPublic

Authored by ldionne on Aug 8 2023, 3:11 PM.

Details

Reviewers
philnik
Mordante
Group Reviewers
Restricted Project
Commits
rG2583946e1fdf: [libc++] Use _LIBCPP_VERBOSE_ABORT from __throw_bad_alloc
Summary

It seems like this one was forgotten and we were still using a raw
std::abort().

Diff Detail

Event Timeline

ldionne created this revision.Aug 8 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 3:11 PM
ldionne requested review of this revision.Aug 8 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 3:11 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Aug 8 2023, 3:14 PM
This revision is now accepted and ready to land.Aug 8 2023, 3:14 PM
Harbormaster completed remote builds in B251214: Diff 548372.Aug 8 2023, 7:44 PM
Mordante accepted this revision.Aug 9 2023, 9:52 AM
Mordante added a subscriber: Mordante.

LGTM! Did you check whether this is the only one forgotten?

ldionne added a comment.Aug 10 2023, 5:31 AM
In D157446#4573594, @Mordante wrote:

LGTM! Did you check whether this is the only one forgotten?

I did, and it should be the last one.

This revision was landed with ongoing or failed builds.Aug 10 2023, 5:32 AM
Closed by commit rG2583946e1fdf: [libc++] Use _LIBCPP_VERBOSE_ABORT from __throw_bad_alloc (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG2583946e1fdf: [libc++] Use _LIBCPP_VERBOSE_ABORT from __throw_bad_alloc.

Revision Contents

PathSize
libcxx/
src/
4 lines

Diff 548372

libcxx/src/new_helpers.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <cstdlib> #include <__verbose_abort>
#include <new> #include <new>
namespace std { // purposefully not versioned namespace std { // purposefully not versioned
#ifndef __GLIBCXX__ #ifndef __GLIBCXX__
const nothrow_t nothrow{}; const nothrow_t nothrow{};
#endif #endif
#ifndef LIBSTDCXX #ifndef LIBSTDCXX
void __throw_bad_alloc() { void __throw_bad_alloc() {
# ifndef _LIBCPP_HAS_NO_EXCEPTIONS # ifndef _LIBCPP_HAS_NO_EXCEPTIONS
throw bad_alloc(); throw bad_alloc();
# else # else
std::abort(); _LIBCPP_VERBOSE_ABORT("bad_alloc was thrown in -fno-exceptions mode");
# endif # endif
} }
#endif // !LIBSTDCXX #endif // !LIBSTDCXX
} // namespace std } // namespace std