[mlir][bufferization] CloneOp: implement memory side-effects in ODS

[springerm]

mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td

195

Looks good, but can you double check that this is actually working. There was some issue in the transform dialect, where we had to implement getEffects manually and could not annotate the arguments/results like this. I forgot what was the reason. Maybe just dump the memory effects to stdout or make sure that some tests are failing if there are no memory effects on CloneOp.

[maerhart]

Add a regression test to check the side-effects on bufferization.clone

mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td

 }
 
 //===----------------------------------------------------------------------===//
 // CloneOp
 //===----------------------------------------------------------------------===//
 
 def Bufferization_CloneOp : Bufferization_Op<"clone", [
     CopyOpInterface,
-    DeclareOpInterfaceMethods<MemoryEffectsOpInterface>,
+    MemoryEffectsOpInterface,
     DeclareOpInterfaceMethods<AllocationOpInterface, ["buildDealloc", "buildClone"]>
   ]> {
   let builders = [
     OpBuilder<(ins "Value":$value), [{
       return build($_builder, $_state, value.getType(), value);
     }]>];
 
   let summary = "clone a memref";
   let description = [{
     Clones the data in the input view into an implicitly defined output view.
 
     Usage:
 
     ```mlir
     %arg1 = bufferization.clone %arg0 : memref<?xf32> to memref<?xf32>
     ```
 
     Valid implementations of this operation may alias the input and output
     views or create an actual copy. Mutating the source or result
     of the clone operation after the clone operation thus leads to undefined
     behavior.
   }];
 
-  let arguments = (ins Arg<AnyRankedOrUnrankedMemRef, "", []>:$input);
-  let results = (outs Arg<AnyRankedOrUnrankedMemRef, "", []>:$output);
+  let arguments = (ins Arg<AnyRankedOrUnrankedMemRef, "",
+                           [MemRead<DefaultResource>]>:$input);
+  let results = (outs Res<AnyRankedOrUnrankedMemRef, "",
+                          [MemWrite<DefaultResource>,
+                           MemAlloc<DefaultResource>]>:$output);
 
   let extraClassDeclaration = [{
     Value getSource() { return getInput(); }
     Value getTarget() { return getOutput(); }
   }];
 
   let assemblyFormat = "$input attr-dict `:` type($input) `to` type($output)";
 

mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp

LogicalResult CopyTensorOp::reifyResultShapes(
   reifiedReturnShapes[0] = tensor::getMixedSizes(builder, getLoc(), getDest());
   return success();
 }
 
 //===----------------------------------------------------------------------===//
 // CloneOp
 //===----------------------------------------------------------------------===//
 
-void CloneOp::getEffects(
-    SmallVectorImpl<SideEffects::EffectInstance<MemoryEffects::Effect>>
-        &effects) {
-  effects.emplace_back(MemoryEffects::Read::get(), getInput(),
-                       SideEffects::DefaultResource::get());
-  effects.emplace_back(MemoryEffects::Write::get(), getOutput(),
-                       SideEffects::DefaultResource::get());
-  effects.emplace_back(MemoryEffects::Allocate::get(), getOutput(),
-                       SideEffects::DefaultResource::get());
-}
-
 OpFoldResult CloneOp::fold(FoldAdaptor adaptor) {
   return succeeded(memref::foldMemRefCast(*this)) ? getResult() : Value();
 }
 
 namespace {
 
 /// Merge the clone and its source (by converting the clone to a cast) when
 /// possible.

mlir/test/Dialect/Bufferization/side-effects.mlir

+// RUN: mlir-opt %s --test-side-effects --verify-diagnostics
+
+func.func @test_side_effects(%arg0: memref<2xi32>) -> memref<2xi32> {
+  // expected-remark @below {{found an instance of 'read' on a value, on resource '<Default>'}}
+  // expected-remark @below {{found an instance of 'write' on a value, on resource '<Default>'}}
+  // expected-remark @below {{found an instance of 'allocate' on a value, on resource '<Default>'}}
+  %0 = bufferization.clone %arg0 : memref<2xi32> to memref<2xi32>
+  // expected-remark @below {{operation has no memory effects}}
+  return %0 : memref<2xi32>
+}