[LLDB] Fix Read/Write memory to be compatible with both endians
ClosedPublic
Actions

Authored by mohit.bhakkad on Dec 22 2015, 10:37 PM.

Details

Reviewers

clayborg
tberghammer

Commits

Summary

While copying a byte, copy a whole byte chunk instead of each bit, to make it compatible with both endians.

mohit.bhakkad retitled this revision from to [LLDB] Fix Read/Write memory to be compatible with both endians.

mohit.bhakkad updated this object.

mohit.bhakkad set the repository for this revision to rL LLVM.

tberghammer requested changes to this revision.Dec 23 2015, 2:57 AM

tberghammer added inline comments.

source/Plugins/Process/Linux/NativeProcessLinux.cpp
2549–2550	This will be a buffer overrun if "size % sizeof(long) != 0" (and also violating strict aliasing). I suggest to use memcpy instead what fixes both of these issue.
2601	Same here

This revision now requires changes to proceed.Dec 23 2015, 2:57 AM

Addressed comment.

LGTM

I can't accept it on the UI because of some bug, but you can commit it without waiting for Greg.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			source/Plugins/Process/Linux/NativeProcessLinux.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43505			Dec 22 2015, 10:31 PM	★	★
Diff 2	43520			Dec 23 2015, 3:43 AM	★	★
Diff 3	43522	256330	Commit rL256331	Dec 23 2015, 4:34 AM	★	★