This is an archive of the discontinued LLVM Phabricator instance.

Differential D157301

[ValueTracking] Add tests for knowing `sdiv` is non-zero; NFC
ClosedPublic

Authored by goldstein.w.n on Aug 7 2023, 10:46 AM.

Details

Reviewers
nikic
Allen
Commits
rGd0b4ed9a2cf3: [ValueTracking] Add tests for knowing `sdiv` is non-zero; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Aug 7 2023, 10:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 10:46 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Aug 7 2023, 10:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 10:46 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D157302: [ValueTracking] Compute `sdiv` as non-zero if `abs(num) u>= abs(denum)`.Aug 7 2023, 10:51 AM
nikic accepted this revision.Aug 7 2023, 11:50 AM

LG

This revision is now accepted and ready to land.Aug 7 2023, 11:50 AM
Harbormaster completed remote builds in B250831: Diff 547847.Aug 7 2023, 2:05 PM
goldstein.w.n updated this revision to Diff 553189.Aug 24 2023, 10:47 AM

Fixup comment/early return

Harbormaster completed remote builds in B254669: Diff 553189.Aug 24 2023, 12:14 PM
This revision was landed with ongoing or failed builds.Aug 24 2023, 5:43 PM
Closed by commit rGd0b4ed9a2cf3: [ValueTracking] Add tests for knowing `sdiv` is non-zero; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGd0b4ed9a2cf3: [ValueTracking] Add tests for knowing `sdiv` is non-zero; NFC.

Revision Contents

PathSize
llvm/
test/
Analysis/
ValueTracking/
47 lines

Diff 553318

llvm/test/Analysis/ValueTracking/known-non-zero.ll

Show First 20 Lines • Show All 1,116 Lines • ▼ Show 20 Lines
; CHECK-NEXT: ret i1 [[NZ]] ; CHECK-NEXT: ret i1 [[NZ]]
; ;
%xx = or i8 %x, 96 %xx = or i8 %x, 96
%yy = or i8 %y, 8 %yy = or i8 %y, 8
%xy = mul i8 %xx, %yy %xy = mul i8 %xx, %yy
%nz = icmp ne i8 %xy, 0 %nz = icmp ne i8 %xy, 0
ret i1 %nz ret i1 %nz
} }
define i1 @sdiv_known_non_zero(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_known_non_zero(
; CHECK-NEXT: [[XX0:%.*]] = or i8 [[X:%.*]], -121
; CHECK-NEXT: [[XX:%.*]] = and i8 [[XX0]], -2
; CHECK-NEXT: [[XY:%.*]] = sdiv i8 [[XX]], -2
; CHECK-NEXT: [[NZ:%.*]] = icmp ne i8 [[XY]], 0
; CHECK-NEXT: ret i1 [[NZ]]
;
%xx0 = or i8 %x, 135
%xx = and i8 %xx0, -2
%xy = sdiv i8 %xx, -2
%nz = icmp ne i8 %xy, 0
ret i1 %nz
}
define i1 @sdiv_known_non_zero2(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_known_non_zero2(
; CHECK-NEXT: [[XX0:%.*]] = or i8 [[X:%.*]], 15
; CHECK-NEXT: [[XX:%.*]] = and i8 [[XX0]], -4
; CHECK-NEXT: [[YY:%.*]] = and i8 [[Y:%.*]], 3
; CHECK-NEXT: [[XY:%.*]] = sdiv i8 [[XX]], [[YY]]
; CHECK-NEXT: [[NZ:%.*]] = icmp ne i8 [[XY]], 0
; CHECK-NEXT: ret i1 [[NZ]]
;
%xx0 = or i8 %x, 15
%xx = and i8 %xx0, -4
%yy = and i8 %y, 3
%xy = sdiv i8 %xx, %yy
%nz = icmp ne i8 %xy, 0
ret i1 %nz
}
define i1 @sdiv_known_non_zero_fail(i8 %x, i8 %y) {
; CHECK-LABEL: @sdiv_known_non_zero_fail(
; CHECK-NEXT: [[XX:%.*]] = or i8 [[X:%.*]], 15
; CHECK-NEXT: [[YY:%.*]] = and i8 [[Y:%.*]], 3
; CHECK-NEXT: [[XY:%.*]] = sdiv i8 [[XX]], [[YY]]
; CHECK-NEXT: [[NZ:%.*]] = icmp ne i8 [[XY]], 0
; CHECK-NEXT: ret i1 [[NZ]]
;
%xx = or i8 %x, 15
%yy = and i8 %y, 3
%xy = sdiv i8 %xx, %yy
%nz = icmp ne i8 %xy, 0
ret i1 %nz
}