This is an archive of the discontinued LLVM Phabricator instance.

[NFC][xray] Fix enable_if usage in XRay.h
ClosedPublic

Authored by ccotter on Aug 6 2023, 12:18 PM.

Details

Summary

The original usage of enable_if does not actually lookup
the nested type called type, so the SFINAE does not kick in.

Diff Detail

Event Timeline

ccotter created this revision.Aug 6 2023, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 12:18 PM
Herald added a subscriber: dberris. · View Herald Transcript
ccotter requested review of this revision.Aug 6 2023, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 12:18 PM
ccotter added inline comments.
llvm/include/llvm/XRay/Graph.h
147

I originally noticed this while writing modernize-use-constraints, and implemented https://reviews.llvm.org/D157239 to find any other similar cases.

kazu accepted this revision.Aug 7 2023, 10:04 AM

Thanks!

This revision is now accepted and ready to land.Aug 7 2023, 10:04 AM

Thanks - @kazu would you mind landing this for me as I do not have merge permissions ("Chris Cotter <ccotter14@bloomberg.net>").

This revision was automatically updated to reflect the committed changes.