This is an archive of the discontinued LLVM Phabricator instance.

Differential D157145

[libc++][PSTL] Disable `-Wpass-failed`.
ClosedPublic

Authored by var-const on Aug 4 2023, 2:57 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG1d340250a894: [libc++][PSTL] Disable `-Wpass-failed`.
Summary

PSTL contains many pragmas that request loop vectorization, which would
produce a warning when the compiler is unable to fulfill the request (if
-Wpass-failed is enabled). This is normal and expected in some cases,
and we don't want -Werror to turn that into a compilation failure.

Diff Detail

Event Timeline

var-const created this revision.Aug 4 2023, 2:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 2:57 PM
Herald added a subscriber: arichardson. · View Herald Transcript
var-const requested review of this revision.Aug 4 2023, 2:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 2:57 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Aug 4 2023, 3:00 PM
This revision is now accepted and ready to land.Aug 4 2023, 3:00 PM
var-const edited the summary of this revision. (Show Details)Aug 4 2023, 3:02 PM
This revision was landed with ongoing or failed builds.Aug 4 2023, 3:12 PM
Closed by commit rG1d340250a894: [libc++][PSTL] Disable `-Wpass-failed`. (authored by var-const). · Explain Why
This revision was automatically updated to reflect the committed changes.
var-const added a commit: rG1d340250a894: [libc++][PSTL] Disable `-Wpass-failed`..
Harbormaster completed remote builds in B250445: Diff 547367.Aug 4 2023, 5:27 PM

Revision Contents

PathSize
libcxx/
utils/
libcxx/
test/
3 lines

Diff 547367

libcxx/utils/libcxx/test/params.py

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines_warningFlags = [
"-Wno-unused-local-typedef", "-Wno-unused-local-typedef",
# Disable warnings for extensions used in C++03 # Disable warnings for extensions used in C++03
"-Wno-local-type-template-args", "-Wno-local-type-template-args",
"-Wno-c++11-extensions", "-Wno-c++11-extensions",
# TODO(philnik) This fails with the PSTL. # TODO(philnik) This fails with the PSTL.
"-Wno-unknown-pragmas", "-Wno-unknown-pragmas",
# Don't fail compilation in case the compiler fails to perform the requested
# loop vectorization.
"-Wno-pass-failed",
] ]
_allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"] _allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"]
def getStdFlag(cfg, std): def getStdFlag(cfg, std):
# TODO(LLVM-17) Remove this clang-tidy-16 work-around # TODO(LLVM-17) Remove this clang-tidy-16 work-around
if std == "c++23": if std == "c++23":
▲ Show 20 Lines • Show All 264 Lines • Show Last 20 Lines