This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Rename AllocatorRingBuffer into scudo:ring_buffer
ClosedPublic

Authored by fabio-d on Aug 4 2023, 8:03 AM.

Details

Summary

To maintain the convention of Scudo names starting with "scudo:",
which is used by some tooling to categorize memory usage.

Diff Detail

Event Timeline

fabio-d created this revision.Aug 4 2023, 8:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 8:03 AM
fabio-d requested review of this revision.Aug 4 2023, 8:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 8:03 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Add @fmayer to be aware of the name change

Add @fmayer to be aware of the name change

I have no concrete concerns about this, but I can definitely imagine something (if only some random scripts) downstream breaking.

Chia-hungDuan accepted this revision.Sep 5 2023, 10:25 AM

Add @fmayer to be aware of the name change

I have no concrete concerns about this, but I can definitely imagine something (if only some random scripts) downstream breaking.

Thanks for sharing your thought. I don't have strong opinion on this either. It's fine to do it.

This revision is now accepted and ready to land.Sep 5 2023, 10:25 AM
This revision was automatically updated to reflect the committed changes.