Add optional args to skip artifact upload and job triggers to clang jobs

[justice_adams]

Summary

In this diff:

• Update the clang jobs with both SKIP_UPLOAD and SKIP_TRIGGER variables which can be set on any jobs targeting the jenkinsfiles, and update the build script invocations accordingly
• Update clang-stage1-RA jobs to run on both green-dragon-02 and green-dragon-08

This will allow us to setup new clang build jobs with different git branches, and the jenkinsfiles will respect the variables set in the job configuration.
See https://green.lab.llvm.org/green/job/clang-stage1-RA-release-17.x, which runs this patch

[azharudd]

We decided to run only the clang-stage1-RA job for the release branch, so the changes to the other jobs aren't really needed?

zorg/jenkins/jobs/jobs/clang-stage1-RA

1–2

This could now run on either of these nodes, but these nodes don't have the same configuration. green-dragon-08 is newer hardware/OS/Xcode whereas green-dragon-02 is older, which could cause issues.

zorg/jenkins/jobs/jobs/clang-stage2-Rthinlto

9 ↗

(On Diff #546951)

We don't really need to skip the upload. It is possible somebody might want to download it and use it locally or debug something. It just gets uploaded to a local server.

[azharudd]

Also, if we are starting to track multiple branches, then best would be to just move to multibranch pipelines.

[justice_adams]

Updated the diff to

• limit changes to clang-stage1-RA
• only skip-triggering new jobs
• Added option to override node config in job config (defaults to green-dragon-02)

[azharudd]

LGTM. Thanks!

[justice_adams]

@azharudd I don't believe I have commit access, could you land this for me?

zorg/jenkins/jobs/jobs/clang-stage1-RA

 pipeline {
-    agent { label 'green-dragon-02' }
-
     parameters {
-        string(name: 'GIT_REVISION', defaultValue: '*/main', description: 'Git revision to build')
+        string(name: 'LABEL', defaultValue: params.LABEL ?: 'green-dragon-02', description: 'Node label to run on')
+
+        string(name: 'GIT_REVISION', defaultValue: params.GIT_REVISION ?: '*/main', description: 'Git revision to build')
+
+        booleanParam(name: 'SKIP_TRIGGER', defaultValue: params.SKIP_TRIGGER ?: false, description: 'Skip trigger of consuming CI jobs')
+    }
+
+    agent {
+        node {
+            label params.LABEL
+        }
     }
 
     stages {
         stage('Checkout') {
             steps {
                 dir('llvm-project') {
                     checkout([$class: 'GitSCM', branches: [
                         [name: params.GIT_REVISION]
post {
                             [$class: 'DevelopersRecipientProvider'],
                             [$class: 'RequesterRecipientProvider'],
                     ],
                     replyTo: '$DEFAULT_REPLYTO',
                     to: '$DEFAULT_RECIPIENTS',
                     body:'$DEFAULT_CONTENT'
         }
         success {
+            script {
+                if (!params.SKIP_TRIGGER) {
                     build job: 'clang-stage2-Rthinlto_relay', wait: false
                     build job: 'clang-stage2-cmake-RgSan_relay', wait: false
                     //build job: 'phase2_modules_relay', wait: false
                     build job: 'relay-lnt-test-suite', wait: false
                     build job: 'relay-lnt-ctmark', wait: false
                     build job: 'relay-test-suite-verify-machineinstrs', wait: false
                 }
+            }
+        }
         unstable {
+            script {
+                if (!params.SKIP_TRIGGER) {
                     build job: 'clang-stage2-Rthinlto_relay', wait: false
                     build job: 'clang-stage2-cmake-RgSan_relay', wait: false
                     //build job: 'phase2_modules_relay', wait: false
                     build job: 'relay-lnt-test-suite', wait: false
                     build job: 'relay-lnt-ctmark', wait: false
                     build job: 'relay-test-suite-verify-machineinstrs', wait: false
                 }
             }
         }
+    }
+}