This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Remove debug RAII from libomptarget
ClosedPublic

Authored by jhuber6 on Aug 3 2023, 6:52 AM.

Details

Summary

This feature was supposed to allow you to trace execution inside of
Libomptarget. However, this never really worked properly. The printing
was always reoganized, only worked for single threads, and pretty much
only told you a handful of things about a runtime library that's an
implementation detail to all users. Despite this, it contributed about
40% of the total filesize of the deviceRTL. This patch simply removes
this functionalit which I think was past due.

Diff Detail

Event Timeline

jhuber6 created this revision.Aug 3 2023, 6:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2023, 6:52 AM
jhuber6 requested review of this revision.Aug 3 2023, 6:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2023, 6:52 AM
tianshilei1992 accepted this revision.Aug 3 2023, 7:24 AM

Yeah, the output is messy TBH. I'm fine with it.

This revision is now accepted and ready to land.Aug 3 2023, 7:24 AM
This revision was automatically updated to reflect the committed changes.